Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/css/main.css

Issue 29551738: Issue 5634 - Replaced logo and refactored navbar width and colors (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Left Patch Set: Moved irrelivant IE CSS from main.css to main-desktop.css where it was originally Created Oct. 10, 2017, 5:37 p.m.
Right Patch Set: Addressed comments Created Oct. 11, 2017, 11:59 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | static/css/main-desktop.css » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 * 1 *
2 { 2 {
3 font-family: Arial, sans; 3 font-family: Arial, sans;
4 font-size: 16px; 4 font-size: 16px;
5 } 5 }
6 6
7 body 7 body
8 { 8 {
9 margin: 0; 9 margin: 0;
10 line-height: 1.5; 10 line-height: 1.5;
(...skipping 227 matching lines...) Expand 10 before | Expand all | Expand 10 after
238 height: 4em; 238 height: 4em;
239 background-color: #c70d2c; 239 background-color: #c70d2c;
240 } 240 }
241 241
242 #navbar li 242 #navbar li
243 { 243 {
244 list-style-type: none; 244 list-style-type: none;
245 } 245 }
246 246
247 /* padding provided by navbar contents */ 247 /* padding provided by navbar contents */
248 #navbar .container 248 .navbar-container
249 { 249 {
250 padding: 0em; 250 width: 1170px;
251 margin: 0 auto;
251 } 252 }
252 253
253 /* full-width under .container max-width */ 254 /* full-width under .container max-width */
254 @media(max-width: 1199px) 255 @media(max-width: 1199px)
255 { 256 {
256 #navbar .container 257 .navbar-container
257 { 258 {
258 width: 100%; 259 width: 100%;
259 } 260 }
260 } 261 }
261 262
262 /* #navbar #navbar-logo 263 /* #navbar #navbar-logo
263 ******************************************************************************/ 264 ******************************************************************************/
264 265
265 #navbar-logo 266 #navbar-logo
266 { 267 {
267 /* padding is visible in hover background-color change */ 268 /* padding is visible in hover background-color change */
268 padding-left: 1em; 269 padding: 0em 1em;
269 padding-right: 1em;
270 color: #fff; 270 color: #fff;
271 } 271 }
272 272
273 #navbar-logo:hover, 273 #navbar-logo:hover,
274 #navbar-logo:active, 274 #navbar-logo:active,
275 #navbar-logo:focus 275 #navbar-logo:focus
276 { 276 {
277 background-color: #AE0013; 277 background-color: #AE0013;
278 text-decoration: none; 278 text-decoration: none;
279 } 279 }
280 280
281 #navbar-logo, 281 #navbar-logo,
282 #navbar-logo > * 282 #navbar-logo > *
283 { 283 {
284 display: block;
ire 2017/10/11 08:09:08 The display doesn't do anything since you are floa
juliandoucette 2017/10/11 11:59:37 I didn't know that :D - Thank you.
285 float: left; 284 float: left;
286 } 285 }
287 286
288 [dir="rtl"] #navbar-logo, 287 [dir="rtl"] #navbar-logo,
289 [dir="rtl"] #navbar-logo > * 288 [dir="rtl"] #navbar-logo > *
290 { 289 {
291 float: right; 290 float: right;
292 } 291 }
293 292
294 #navbar-logo img 293 #navbar-logo img
295 { 294 {
296 height: 4em; 295 height: 4em;
297 padding-top: 0.5em; 296 padding: 0.5em 0em;
298 padding-bottom: 0.5em; 297 margin: 0em 1em 0em 0em;
299 margin-right: 1em;
ire 2017/10/11 08:09:09 This margin-right still applies when direction is
juliandoucette 2017/10/11 11:59:36 Good catch!
300 } 298 }
301 299
302 [dir="rtl"] #navbar-logo > img 300 [dir="rtl"] #navbar-logo > img
303 { 301 {
304 margin-left: 1em; 302 margin: 0em 0em 0em 1em;
305 } 303 }
306 304
307 #navbar-logo > span 305 #navbar-logo > span
308 { 306 {
309 /* full-height: 2.91 * 1.375 = ~4em */ 307 /* full-height: 2.91 * 1.375 = ~4em */
ire 2017/10/11 08:09:07 Helpful comments, thanks :)
juliandoucette 2017/10/11 11:59:35 You're welcome.
310 line-height: 2.91em; 308 line-height: 2.91em;
311 font-size: 1.375em; 309 font-size: 1.375em;
312 } 310 }
313 311
314 /* #navbar #navbar-menu-toggle 312 /* #navbar #navbar-menu-toggle
315 ******************************************************************************/ 313 ******************************************************************************/
316 314
317 #navbar-menu-toggle 315 #navbar-menu-toggle
318 { 316 {
319 float: right; 317 float: right;
(...skipping 41 matching lines...) Expand 10 before | Expand all | Expand 10 after
361 { 359 {
362 display: block; 360 display: block;
363 color: #fff; 361 color: #fff;
364 text-decoration: none; 362 text-decoration: none;
365 } 363 }
366 364
367 /* #navbar #navbar-menu #navbar-locale-menu 365 /* #navbar #navbar-menu #navbar-locale-menu
368 ******************************************************************************/ 366 ******************************************************************************/
369 367
370 /* caret */ 368 /* caret */
371 #navbar-locale-selected::after 369 #navbar-locale-selected:after
ire 2017/10/11 08:09:07 Single colon for :after
juliandoucette 2017/10/11 11:59:35 Done.
372 { 370 {
373 display: inline-block; 371 display: inline-block;
374 width: 0; 372 width: 0;
375 height: 0; 373 height: 0;
376 margin-left: .255em; 374 margin: 0em 0em 0em 0.255em;
ire 2017/10/11 08:09:09 "Don't omit the optional leading 0 for decimal num
juliandoucette 2017/10/11 11:59:35 Good catch. Looks like I neglected rtl too.
377 vertical-align: .255em; 375 vertical-align: .255em;
378 content: ""; 376 content: "";
379 border-top: .3em solid; 377 border-top: .3em solid;
380 border-right: .3em solid transparent; 378 border-right: .3em solid transparent;
381 border-left: .3em solid transparent; 379 border-left: .3em solid transparent;
382 } 380 }
383 381
382 [dir="rtl"] #navbar-locale-selected:after
383 {
384 margin: 0em 0.255em 0em 0em;
385 }
386
384 #navbar-locale-menu 387 #navbar-locale-menu
385 { 388 {
386 display: none; 389 display: none;
387 } 390 }
388 391
389 #navbar-locale-menu.visible 392 #navbar-locale-menu.visible
390 { 393 {
391 display: block; 394 display: block;
392 } 395 }
393 396
(...skipping 25 matching lines...) Expand all
419 } 422 }
420 423
421 #navbar-menu > li, 424 #navbar-menu > li,
422 #navbar-menu > li > a 425 #navbar-menu > li > a
423 { 426 {
424 display: inline-block; 427 display: inline-block;
425 } 428 }
426 429
427 #navbar-menu > li > a 430 #navbar-menu > li > a
428 { 431 {
429 padding-right: 1em; 432 padding: 0em 1em;
430 padding-left: 1em;
431 line-height: 4em; 433 line-height: 4em;
432 } 434 }
433 435
434 #navbar-menu > li > a:hover, 436 #navbar-menu > li > a:hover,
435 #navbar-menu > li > a:active, 437 #navbar-menu > li > a:active,
436 #navbar-menu > li > a:focus 438 #navbar-menu > li > a:focus
437 { 439 {
438 background-color: #AE0013; 440 background-color: #AE0013;
439 } 441 }
440 442
441 /* #navbar #navbar-menu #navbar-locale-menu 443 /* #navbar #navbar-menu #navbar-locale-menu
442 ****************************************************************************/ 444 ****************************************************************************/
443 445
444 #navbar-locale-menubar 446 #navbar-locale-menubar
445 { 447 {
446 position: relative; 448 position: relative;
447 } 449 }
448 450
449 #navbar-locale-menu 451 #navbar-locale-menu
450 { 452 {
451 position: absolute; 453 position: absolute;
452 min-width: 16em; 454 min-width: 16em;
453 max-height: 20em; 455 max-height: 20em;
454 max-height: 50vh; 456 max-height: 50vh;
455 top: 100%; 457 top: 100%;
456 right: 0px; 458 right: 0px;
457 overflow: auto; 459 overflow: auto;
458 z-index: 1000; 460 z-index: 9001;
ire 2017/10/11 08:09:09 NIT: A lower z-index (e.g. even 1 or 2) would suff
juliandoucette 2017/10/11 11:59:36 pfft
459 background-color: #292929; 461 background-color: #292929;
460 } 462 }
461 463
462 [dir="rtl"] #navbar-locale-menu 464 [dir="rtl"] #navbar-locale-menu
463 { 465 {
464 right: auto; 466 right: auto;
465 left: 0px; 467 left: 0px;
466 } 468 }
467 } 469 }
468 470
(...skipping 21 matching lines...) Expand all
490 padding: 0.75em 1em; 492 padding: 0.75em 1em;
491 } 493 }
492 494
493 #navbar-menu li a:hover, 495 #navbar-menu li a:hover,
494 #navbar-menu li a:active, 496 #navbar-menu li a:active,
495 #navbar-menu li a:focus 497 #navbar-menu li a:focus
496 { 498 {
497 background-color: #434343; 499 background-color: #434343;
498 } 500 }
499 } 501 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld