Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: static/js/main.js

Issue 29551738: Issue 5634 - Replaced logo and refactored navbar width and colors (Closed) Base URL: https://hg.adblockplus.org/web.adblockplus.org
Patch Set: Fixed navbar-logo-2x Created Sept. 28, 2017, 1:03 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: static/js/main.js
===================================================================
--- a/static/js/main.js
+++ b/static/js/main.js
@@ -42,17 +42,17 @@
&& typeof window.event.cancelBubble !== "undefined")
window.event.cancelBubble = true;
else
event.stopPropagation();
}
function initLanguageSelection()
{
- var language = document.getElementById("language");
+ var language = document.getElementById("locale");
// skip if page does not have language selection (EG: blog)
if (!language)
return;
var languageSelection = language.getElementsByTagName("ul")[0];
document.documentElement.onclick = function()
@@ -73,33 +73,33 @@
function navigationClick(event)
{
var element = event.target;
while (true)
{
if (!element)
return;
- if (hasClass(element, "selected") || element.id == "hamburger")
+ if (hasClass(element, "selected") || element.id == "navbar-menu")
{
if ("querySelector" in document)
ire 2017/09/28 08:38:44 This if statement is no longer needed since you're
juliandoucette 2017/10/04 15:33:28 Acknowledged.
{
event.preventDefault();
- toggleClass(document.querySelector("header nav > ul"), "visible");
+ toggleClass(document.getElementById("navbar-nav"), "visible");
}
return false;
}
element = element.parentElement;
}
}
function initMenu()
{
if ("querySelector" in document)
- document.querySelector("header nav").onclick = navigationClick;
+ document.getElementById("navbar-menu").onclick = navigationClick;
ire 2017/09/28 08:38:44 This if statement is no longer needed since you're
juliandoucette 2017/10/04 15:33:28 Acknowledged.
}
function initFooterSection(section)
{
var header = section.getElementsByTagName("h1")[0];
header.onclick = function()
{
toggleClass(section, "visible");

Powered by Google App Engine
This is Rietveld