Issue 5750 - Always require subscriptionInit, avoid "critical dependency"

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 31 matching lines @@
     SpecialSubscription
   } = require("subscriptionClasses");
 
   port.on("types.get", (message, sender) =>
   {
     let filterTypes = Array.from(require("requestBlocker").filterTypes);
     filterTypes.push(...filterTypes.splice(filterTypes.indexOf("OTHER"), 1));
     return filterTypes;
   });
 
-  // Some modules doesn't exist on Firefox. Moreover,
-  // require() throws an exception on Firefox in that case.
-  // However, try/catch causes the whole function to to be
-  // deoptimized on V8. So we wrap it into another function.
-  function tryRequire(module)
-  {
-    try
-    {
-      return require(module);
-    }
-    catch (e)
-    {
-      return null;
-    }
-  }
-
   function convertObject(keys, obj)
   {
     let result = {};
     for (let key of keys)
     {
       if (key in obj)
         result[key] = obj[key];
     }
     return result;
   }
@@ skipping 81 matching lines @@
       listenerFilters = Object.create(null);
       changeListeners.set(page, listenerFilters);
     }
     return listenerFilters;
   }
 
   port.on("app.get", (message, sender) =>
   {
     if (message.what == "issues")
     {
-      let subscriptionInit = tryRequire("subscriptionInit");
+      let subscriptionInit = require("subscriptionInit");
       let result = subscriptionInit ? subscriptionInit.reinitialized : false;
       return {filterlistsReinitialized: result};
     }
 
     if (message.what == "doclink")
       return Utils.getDocLink(message.link);
 
     if (message.what == "localeInfo")
     {
       let bidiDir;
@@ skipping 261 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);