Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29552704: Noissue - Gave Dave "Peer" status for the Core module (Closed)

Created:
Sept. 22, 2017, 3:58 p.m. by kzar
Modified:
Sept. 23, 2017, 9:14 a.m.
CC:
Wladimir Palant
Visibility:
Public.

Description

Noissue - Gave Dave "Peer" status for the Core module

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M pages/modules.html View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4
kzar
Patch Set 1
Sept. 22, 2017, 3:58 p.m. (2017-09-22 15:58:50 UTC) #1
Sebastian Noack
LGTM
Sept. 22, 2017, 4:01 p.m. (2017-09-22 16:01:51 UTC) #2
Felix Dahlke
LGTM, with one caveat: This excludes the C++ code in the emscripten branch for now ...
Sept. 22, 2017, 4:07 p.m. (2017-09-22 16:07:48 UTC) #3
kzar
Sept. 23, 2017, 8:37 a.m. (2017-09-23 08:37:04 UTC) #4
On 2017/09/22 16:07:48, Felix Dahlke wrote:
> LGTM, with one caveat: This excludes the C++ code in the emscripten branch for
> now - there would have to be more contribution first. There is no need to try
> and communicate that on ABP.org/modules, just wanted to say it here.

Yep, totally agree there, I don't know much if any C++ yet.

Powered by Google App Engine
This is Rietveld