Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: make_gyp_wrapper.py

Issue 29555620: Issue 5698 - Update V8 to 6.1.534.41 (Closed) Base URL: https://github.com/adblockplus/libadblockplus.git
Patch Set: fix and rebase Created Sept. 28, 2017, 7:21 a.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
« dependencies ('K') | « dependencies ('k') | msvs_gyp_wrapper.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: make_gyp_wrapper.py
diff --git a/make_gyp_wrapper.py b/make_gyp_wrapper.py
index 641e64c626f8696fd1e23f3fa9c539d278f32456..d398feb41c0c4aedd1fe347cdc1ae40d1c35967a 100644
--- a/make_gyp_wrapper.py
+++ b/make_gyp_wrapper.py
@@ -119,15 +119,5 @@ def overridden_WriteAndroidNdkModuleRule(self, module_name, all_sources, link_de
MakefileWriter.Write = overridden_Write
MakefileWriter.WriteAndroidNdkModuleRule = overridden_WriteAndroidNdkModuleRule
-# Issue 5393
sergei 2017/09/28 07:36:38 It's fixed in v8.gyp, see the change of the order
-# replace $(LD_INPUTS) by "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" but
-# only for cmd_link_host and only on linux.
-print platform.system()
-if platform.system() == "Linux":
- gyp.generator.make.LINK_COMMANDS_ANDROID = \
- gyp.generator.make.LINK_COMMANDS_ANDROID[:663] + \
- "-Wl,--start-group $(LD_INPUTS) -Wl,--end-group" + \
- gyp.generator.make.LINK_COMMANDS_ANDROID[675:]
-
if __name__ == '__main__':
gyp.main(sys.argv[1:])
« dependencies ('K') | « dependencies ('k') | msvs_gyp_wrapper.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld