Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(95)

Issue 29555778: Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Sebastian Noack
Modified:
2 years, 1 month ago
Reviewers:
Manish Jethani, kzar
Visibility:
Public.

Description

Issue 5776 - Updated adblockpluscore dependency to d4ed3916793a

Patch Set 1 : #

Patch Set 2 : Include latest core changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -112 lines) Patch
M dependencies View 1 1 chunk +1 line, -1 line 0 comments Download
M include.preload.js View 1 2 chunks +1 line, -5 lines 0 comments Download
M lib/compat.js View 3 chunks +16 lines, -106 lines 0 comments Download

Messages

Total messages: 6
Sebastian Noack
2 years, 1 month ago (2017-09-25 15:25:00 UTC) #1
Sebastian Noack
I updated the patch (and the issue) to also account for the the latest changes ...
2 years, 1 month ago (2017-09-27 21:23:20 UTC) #2
kzar
Nice to finally remove some of this shit! LGTM
2 years, 1 month ago (2017-09-28 09:29:41 UTC) #3
Manish Jethani
LGTM
2 years, 1 month ago (2017-09-28 11:03:48 UTC) #4
Manish Jethani
On 2017/09/28 11:03:48, Manish Jethani wrote: > LGTM I found a reference to nsIFile in ...
2 years, 1 month ago (2017-09-28 11:05:30 UTC) #5
Sebastian Noack
2 years, 1 month ago (2017-09-28 21:29:10 UTC) #6
On 2017/09/28 11:05:30, Manish Jethani wrote:
> I found a reference to nsIFile in the adblockpluscore comments that is
probably
> outdated:
> 
>
https://hg.adblockplus.org/adblockpluscore/file/d4ed3916793a/lib/filterStorag...

It seems so. This jsdoc comment defines FileInfo with a property of the type
nsIFile. The function below is documented to return a Promise that resolves to
an array of FileInfo, which is the only reference to FileInfo in this file.
However, it is obvious, by looking at the code, that the return value of that
function rather looks like [{index, lastModified}]. So yeah, the jsdoc comments
are outdated there.
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5