Issue 5701 - Inconsistent forum links and DNT link

messageResponder.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 139 matching lines @@
   {
     if (message.what == "issues")
     {
       let subscriptionInit = require("subscriptionInit");
       let result = subscriptionInit ? subscriptionInit.reinitialized : false;
       return {filterlistsReinitialized: result};
     }
 
     if (message.what == "doclink")
     {
-      let {application, platform} = info;

[Sebastian Noack, 2017/09/25 21:03:22]

Nit: I personally wouldn't assign "platform" to a local variable. That way you
merely save typing "info" twice, but have to type "platform" one more time. Also
IMO it is slightly less obvious that we are only modifying application in the
logic here. But it might just be personal preference, so feel free to ignore.

[saroyanm, 2017/09/25 21:21:45]

Done.

-      if (platform == "chromium" && application != "opera")
+      let {application} = info;
+      if (info.platform == "chromium" && application != "opera")
         application = "chrome";
-      else if (platform == "gecko")
+      else if (info.platform == "gecko")
         application = "firefox";
 
-      let link = message.link.replace("{application}", application);
-      return Utils.getDocLink(link);

[Sebastian Noack, 2017/09/25 21:03:22]

Nit: Why a temporary variable, and not just return in the line above?

[saroyanm, 2017/09/25 21:17:33]

Exceeded 80 char limit.

[saroyanm, 2017/09/25 21:28:00]

Done.

+      return Utils.getDocLink(message.link.replace("{browser}", application));
     }
 
     if (message.what == "localeInfo")
     {
       let bidiDir;
       if ("chromeRegistry" in Utils)
       {
         let isRtl = Utils.chromeRegistry.isLocaleRTL("adblockplus");
         bidiDir = isRtl ? "rtl" : "ltr";
       }
@@ skipping 256 matching lines @@
     if (message.url)
       subscriptions = [Subscription.fromURL(message.url)];
 
     for (let subscription of subscriptions)
     {
       if (subscription instanceof DownloadableSubscription)
         Synchronizer.execute(subscription, true);
     }
   });
 })(this);