Issue 5701 - Inconsistent forum links and DNT link

messageResponder.js

Index: messageResponder.js
===================================================================
--- a/messageResponder.js
+++ b/messageResponder.js
@@ -156,7 +156,16 @@
     }
 
     if (message.what == "doclink")
-      return Utils.getDocLink(message.link);
+    {
+      let {application, platform} = info;

[Sebastian Noack, 2017/09/25 21:03:22]

Nit: I personally wouldn't assign "platform" to a local variable. That way you
merely save typing "info" twice, but have to type "platform" one more time. Also
IMO it is slightly less obvious that we are only modifying application in the
logic here. But it might just be personal preference, so feel free to ignore.

[saroyanm, 2017/09/25 21:21:45]

Done.

+      if (platform == "chromium" && application != "opera")
+        application = "chrome";
+      else if (platform == "gecko")
+        application = "firefox";
+
+      let link = message.link.replace("{application}", application);
+      return Utils.getDocLink(link);

[Sebastian Noack, 2017/09/25 21:03:22]

Nit: Why a temporary variable, and not just return in the line above?

[saroyanm, 2017/09/25 21:17:33]

Exceeded 80 char limit.

[saroyanm, 2017/09/25 21:28:00]

Done.

+    }
 
     if (message.what == "localeInfo")
     {