Issue 5336 - Allow additional include, page, and template paths using CMS

cms/sources.py

 # This file is part of the Adblock Plus web scripts,
 # Copyright (C) 2006-present eyeo GmbH
 #
 # Adblock Plus is free software: you can redistribute it and/or modify
 # it under the terms of the GNU General Public License version 3 as
 # published by the Free Software Foundation.
 #
 # Adblock Plus is distributed in the hope that it will be useful,
 # but WITHOUT ANY WARRANTY; without even the implied warranty of
 # MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
@@ skipping 339 matching lines @@
 
     def wrapper(*args):
         try:
             return memoized[args]
         except KeyError:
             return memoized.setdefault(args, func(*args))
     wrapper.cache_clear = memoized.clear
     return wrapper
 
 
-def create_source(path, static=False, revision=None):

[Sebastian Noack, 2017/09/29 19:11:30]

Does it still make sense to call that argument "static"? Whether the output will
be statically generated or delivered on the fly is an implementation detail of
the calling code. Since now this flag is only used to turn on caching, why not
just calling it "cached"?

[Vasily Kuznetsov, 2017/10/02 11:11:56]

Yeah, you're right, now it would be more clear if it's just a caching flag.

Done.

+def create_source(path, cached=False, revision=None):
     """Create a source from path and optional revision.
 
-    `static` flag indicates that the website source under `path` can be assumed
-    to not change after the source was created and any changes can be safely
-    ignored.
-    - If `static` is `True`, no interim changes are expected and caching will
-      be used to optimize performance.
-    - If `static` is `False`, changes on the filesystem are expected and will
-      be reflected in the outputs of the calls. This mode can be used for live
-      preview.
+    `cached` flag activates caching. This can be used to optimize performance
+    if no changes are expected on the filesystem after the source was created.
+    This is usually the case with static generation (as opposed to dynamic
+    preview).
 
     If `revision` option is provided, the `path` is assumed to be pointing to a
     Mercurial repository. In this case the source will return the content of
     selected revision (using `MercurialSource`) instead of the content of the
     directory. Note that any local changes will be ignored in this case.
 
     If `settings.ini` in the source contains `[paths]` section with an
     `additional-paths` key that contains the list of additional root folders,
     `MultiSource` will be instantiated and its bases will be the original
     source plus an additional source for each additional root folder.
@@ skipping 13 matching lines @@
     except (ConfigParser.NoSectionError, ConfigParser.NoOptionError):
         additional_paths = []
 
     if additional_paths:
         additional_sources = [
             create_source(os.path.join(path, p))
             for p in additional_paths
         ]
         source = MultiSource([source] + additional_sources)
 
-    if static:
+    if cached:
         for fname in [
             'resolve_link',
             'read_config',
             'read_template',
             'read_locale',
             'read_include',
             'exec_file',
         ]:
             setattr(source, fname, _memoize(getattr(source, fname)))
 
     return source