Issue 5643 - Make v8::Isolate injectable into JsEngine

libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
   {
     this(ctor(logSystem, webRequest, basePath));
   }
 
   protected Platform(final long ptr)
   {
     this.ptr = ptr;
     this.disposer = new Disposer(this, new DisposeWrapper(ptr));
   }
 
-  public void setUpJsEngine(final AppInfo appInfo, final Long v8IsolatePtr)

[sergei, 2017/09/26 09:44:13]

Why not to use primitive value here and in AdblockHelper.java?

[anton, 2017/09/26 10:55:06]

There is almost no difference.
I will use primitive if you insist.

+  public void setUpJsEngine(final AppInfo appInfo, final long v8IsolatePtr)
   {
-    setUpJsEngine(this.ptr, appInfo, (v8IsolatePtr != null ? v8IsolatePtr.longValue() : 0L));
+    setUpJsEngine(this.ptr, appInfo, v8IsolatePtr);
   }
 
   public void setUpJsEngine(final AppInfo appInfo)
   {
-    setUpJsEngine(appInfo, null);
+    setUpJsEngine(appInfo, 0L);
   }
 
   public JsEngine getJsEngine()
   {
     return new JsEngine(getJsEnginePtr(this.ptr));
   }
 
   public void setUpFilterEngine(final IsAllowedConnectionCallback isSubscriptionDownloadAllowedCallback)
   {
     setUpFilterEngine(this.ptr, isSubscriptionDownloadAllowedCallback);
@@ skipping 38 matching lines @@
   private final static native void setUpJsEngine(long ptr, AppInfo appInfo, long v8IsolatePtr);
 
   private final static native long getJsEnginePtr(long ptr);
 
   private final static native void setUpFilterEngine(long ptr, IsAllowedConnectionCallback isSubscriptionDownloadAllowedCallback);
 
   private final static native void ensureFilterEngine(long ptr);
 
   private final static native void dtor(long ptr);
 }