Unified Diff: libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java
Issue 29556582:
Issue 5643 - Make v8::Isolate injectable into JsEngine (Closed)
Patch Set:
Created Sept. 26, 2017, 8:54 a.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« libadblockplus-android/jni/JniPlatform.cpp ('K')
|
« libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java ('k')
|
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java |
| diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java |
| index 727af68691a6432c26b8cf06e2fbe51646739448..cdb71f77798c1cb4a8e8bb1175beedb2431f0516 100644 |
| --- a/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java |
| +++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/Platform.java |
| @@ -45,9 +45,14 @@ public class Platform implements Disposable |
| this.disposer = new Disposer(this, new DisposeWrapper(ptr)); |
| } |
| + public void setUpJsEngine(final AppInfo appInfo, final Long v8IsolatePtr) |
|
sergei
2017/09/26 09:44:13
Why not to use primitive value here and in Adblock
anton
2017/09/26 10:55:06
There is almost no difference.
I will use primitiv
|
| + { |
| + setUpJsEngine(this.ptr, appInfo, (v8IsolatePtr != null ? v8IsolatePtr.longValue() : 0L)); |
| + } |
| + |
| public void setUpJsEngine(final AppInfo appInfo) |
| { |
| - setUpJsEngine(this.ptr, appInfo); |
| + setUpJsEngine(appInfo, null); |
| } |
| public JsEngine getJsEngine() |
| @@ -96,7 +101,7 @@ public class Platform implements Disposable |
| private final static native long ctor(LogSystem logSystem, WebRequest webRequest, String basePath); |
| - private final static native void setUpJsEngine(long ptr, AppInfo appInfo); |
| + private final static native void setUpJsEngine(long ptr, AppInfo appInfo, long v8IsolatePtr); |
| private final static native long getJsEnginePtr(long ptr); |
« libadblockplus-android/jni/JniPlatform.cpp ('K')
|
« libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java ('k')
|
libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('j')
|
no next file with comments »
