libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java - Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

Issue 29556582: Issue 5643 - Make v8::Isolate injectable into JsEngine (Closed)

Patch Set: Using JniLongToTypePtr for casting Created Sept. 28, 2017, 8:55 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | libadblockplus-android/jni/JniPlatform.cpp » ('j') | libadblockplus-android/src/org/adblockplus/libadblockplus/android/AdblockEngine.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

diff --git a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

index 41592ace84661ace8e97c007e5a9caec66dc8e37..414a45fa1cdb4af80b6bf3e2ebbd10b871b65fda 100644

--- a/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

+++ b/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/AdblockHelper.java

@@ -59,6 +59,7 @@ public class AdblockHelper

private AdblockEngine engine;

private AdblockSettingsStorage storage;

private CountDownLatch engineCreated;

+ private Long v8IsolatePtr;

Simple ARC management for AdblockEngine

@@ -131,6 +132,11 @@ public class AdblockHelper

return this;

}

+ public void useV8Isolate(long ptr)

+ {

+ this.v8IsolatePtr = ptr;

+ }

private void createAdblock()

{

ConnectivityManager connectivityManager =

@@ -152,6 +158,11 @@ public class AdblockHelper

.setIsAllowedConnectionCallback(isAllowedConnectionCallback)

.enableElementHiding(true);

+ if (v8IsolatePtr != null)

+ {

+ builder.useV8Isolate(v8IsolatePtr);

+ }

// if preloaded subscriptions provided

if (preloadedPreferenceName != null)

{