Issue 5690 - Create Article Template for help.eyeo.com

static/scss/components/_article.scss

Index: static/scss/components/_article.scss
===================================================================
new file mode 100644
--- /dev/null
+++ b/static/scss/components/_article.scss
@@ -0,0 +1,35 @@
+// This file is part of help.eyeo.com.
+// Copyright (C) 2017 Eyeo GmbH
+//
+// help.eyeo.com is free software: you can redistribute it and/or modify
+// it under the terms of the GNU General Public License as published by
+// the Free Software Foundation, either version 3 of the License, or
+// (at your option) any later version.
+//
+// help.eyeo.com is distributed in the hope that it will be useful,
+// but WITHOUT ANY WARRANTY; without even the implied warranty of
+// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+// GNU General Public License for more details.
+//
+// You should have received a copy of the GNU General Public License
+// along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
+
+// Article ////////////////////////////////////////////////////////////////
+
+.article.card
+{
+  padding: $md;
+
+  @media (min-width: $phablet-breakpoint)
+  {
+    padding: $lg;

[juliandoucette, 2017/10/09 12:53:59]

NIT: p contains margin-bottom. As a result, the space at the bottom of most
cards will be .article padding-bottom + p margin-bottom.  I'm not sure what, if
anything, we should do about this. [we could make this padding-bottom less, we
could make p margin-bottom less, we could allow more space at the bottom] 

This seems like a question that I should already have a good answer to based on
experience :/ :D

[ire, 2017/10/09 19:48:06]

Hmm, I'm unsure about if I think this needs to be addressed. My thoughts:

1. I don't think we should change the margin/padding on the p or this .article,
because we can't be certain the the last bit of content will even be a paragraph
(e.g. it could be an image, blockquote, etc).

2. I don't think the extra space makes the design look off

3. Because of 1 & 2, I would be fine doing a `.article p:last-of-type` selector
to remove the margin-bottom, and have this only apply to browsers that do
support that selector

Nonetheless, I will create an issue and we can discuss this further there.

[ire, 2017/10/09 19:48:06]

https://issues.adblockplus.org/ticket/5849#ticket

+  }
+}
+
+.article-heading,
+.article-browser-selector
+{
+  padding-bottom: $md;
+  margin-bottom: $md;
+  border-bottom: 1px dotted $gray;
+}