Issue 5790 - Get ready for integration into Chromium

libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java

Index: libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
diff --git a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java b/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
index 720223e4d5a6363e2c5623722a5159c293bc7e0a..416d569680b70e82eb491a1802d8cd076c7cd5fc 100644
--- a/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
+++ b/libadblockplus-android/src/org/adblockplus/libadblockplus/FilterEngine.java
@@ -196,6 +196,14 @@ public final class FilterEngine
     updateFiltersAsync(this.ptr, subscriptionUrl);
   }
 
+  /**
+   * Get FilterEngine pointer
+   * @return C++ FilterEngine instance pointer
+   */
+  public long getFilterEnginePtr() {

[sergei, 2017/09/26 12:04:29]

Maybe call it `getNativePtr`?

[anton, 2017/09/26 12:18:40]

Does not make sense for me, we can call it `getNativePtr `

[sergei, 2017/09/28 08:29:03]

I don't insist, it's just my expectations of an API. This method is rather for
some internal and very advanced usages and it's a common practice to have a
convention that such methods like `getNative`, `getHandle`, etc, providing the
access to an internal structure and they should not duplicate the name of the
class. So if there is a need to expose the underlying handle from JsValue,
Platform or some another class wrapping a native resource one can always get it
through such method.

http://en.cppreference.com/w/cpp/thread/thread/native_handle
http://www.boost.org/doc/libs/1_64_0/doc/html/thread/thread_management.html#t...

+    return getFilterEnginePtr(this.ptr);
+  }
+
   private final static native void registerNatives();
 
   private final static native boolean isFirstRun(long ptr);
@@ -253,4 +261,6 @@ public final class FilterEngine
   private final static native String getAcceptableAdsSubscriptionURL(long ptr);
 
   private final static native void updateFiltersAsync(long ptr, String subscriptionUrl);
+
+  private final static native long getFilterEnginePtr(long ptr);
 }