Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(254)

Issue 29556638: Issue 5762 - Use relative require paths (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 11 months ago by hub
Modified:
1 year, 7 months ago
Reviewers:
sergei, kzar
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5762 - Use relative require paths

Patch Set 1 #

Total comments: 12

Patch Set 2 : rebased #

Patch Set 3 : Use a path alias for the common modules. #

Patch Set 4 : Don't use a module path for the modules provided by the "client" #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -31 lines) Patch
M lib/content/elemHideEmulation.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/elemHide.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/elemHideEmulation.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/filterClasses.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/filterListener.js View 3 1 chunk +6 lines, -6 lines 0 comments Download
M lib/filterNotifier.js View 1 chunk +2 lines, -2 lines 0 comments Download
M lib/filterStorage.js View 3 1 chunk +3 lines, -3 lines 0 comments Download
M lib/matcher.js View 1 chunk +1 line, -1 line 0 comments Download
M lib/notification.js View 3 1 chunk +4 lines, -3 lines 0 comments Download
M lib/subscriptionClasses.js View 1 chunk +3 lines, -3 lines 0 comments Download
M lib/synchronizer.js View 3 1 chunk +6 lines, -5 lines 0 comments Download

Messages

Total messages: 17
hub
1 year, 11 months ago (2017-09-26 13:29:36 UTC) #1
kzar
Thanks for helping out with this one. I guess this might need to be rebased ...
1 year, 10 months ago (2017-10-18 15:12:08 UTC) #2
hub
I have skipped deliberately out of tree modules because we can't reference them reliably. They ...
1 year, 10 months ago (2017-10-18 17:57:45 UTC) #3
hub
rebasing led to no changes it seems.
1 year, 10 months ago (2017-10-18 18:04:41 UTC) #4
kzar
On 2017/10/18 17:57:45, hub wrote: > I have skipped deliberately out of tree modules because ...
1 year, 10 months ago (2017-10-20 13:51:30 UTC) #5
sergei
On 2017/10/20 13:51:30, kzar wrote: > On 2017/10/18 17:57:45, hub wrote: > > I have ...
1 year, 7 months ago (2018-01-03 12:57:18 UTC) #6
hub
I followed sergei suggestion to use "abp-modules" as path prefix. We'll need to change the ...
1 year, 7 months ago (2018-01-03 20:13:42 UTC) #7
kzar
On 2018/01/03 12:57:18, sergei wrote: > IMO such paths like ../../lib/prefs.js and ../../buildtools/info are pretty ...
1 year, 7 months ago (2018-01-04 13:10:20 UTC) #8
sergei
On 2018/01/04 13:10:20, kzar wrote: > On 2018/01/03 12:57:18, sergei wrote: > > > IMO ...
1 year, 7 months ago (2018-01-04 13:17:07 UTC) #9
kzar
On 2018/01/04 13:17:07, sergei wrote: > IMO such paths like ../../lib/prefs.js and ../../buildtools/info are pretty ...
1 year, 7 months ago (2018-01-04 14:22:14 UTC) #10
sergei
On 2018/01/04 14:22:14, kzar wrote: > On 2018/01/04 13:17:07, sergei wrote: > > > IMO ...
1 year, 7 months ago (2018-01-04 15:49:10 UTC) #11
hub
On 2018/01/04 15:49:10, sergei wrote: > In general I am still not convinced to have ...
1 year, 7 months ago (2018-01-04 17:05:07 UTC) #12
kzar
On 2018/01/04 15:49:10, sergei wrote: > Actually the implementation in libadblockplus is pretty hacky and ...
1 year, 7 months ago (2018-01-04 18:06:14 UTC) #13
hub
> > Assuming as specific layout for the "client" of adblockpluscore (ie the > > ...
1 year, 7 months ago (2018-01-04 20:54:51 UTC) #14
hub
patch updated.
1 year, 7 months ago (2018-01-04 21:01:52 UTC) #15
sergei
LGTM
1 year, 7 months ago (2018-01-05 08:21:42 UTC) #16
kzar
1 year, 7 months ago (2018-01-05 14:20:40 UTC) #17
LGTM
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5