Issue 5762 - Use relative require paths

lib/synchronizer.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
  *
  * You should have received a copy of the GNU General Public License
  * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
  */
 
 "use strict";
 
 /**
  * @fileOverview Manages synchronization of filter subscriptions.
  */
 
 const {Downloader, Downloadable,
        MILLIS_IN_SECOND, MILLIS_IN_MINUTE,
-       MILLIS_IN_HOUR, MILLIS_IN_DAY} = require("downloader");
-const {Filter} = require("filterClasses");
-const {FilterStorage} = require("filterStorage");
-const {FilterNotifier} = require("filterNotifier");
+       MILLIS_IN_HOUR, MILLIS_IN_DAY} = require("./downloader");
+const {Filter} = require("./filterClasses");
+const {FilterStorage} = require("./filterStorage");
+const {FilterNotifier} = require("./filterNotifier");
 const {Prefs} = require("prefs");

[kzar, 2017/10/18 15:12:08]

You missed this one.

[hub, 2017/10/18 17:57:45]

out of tree module.

-const {Subscription, DownloadableSubscription} = require("subscriptionClasses");
+const {Subscription,
+       DownloadableSubscription} = require("./subscriptionClasses");
 const {Utils} = require("utils");
 
 const INITIAL_DELAY = 1 * MILLIS_IN_MINUTE;
 const CHECK_INTERVAL = 1 * MILLIS_IN_HOUR;
 const DEFAULT_EXPIRATION_INTERVAL = 5 * MILLIS_IN_DAY;
 
 /**
  * The object providing actual downloading functionality.
  * @type {Downloader}
  */
@@ skipping 259 matching lines @@
     {
       subscription.errors++;
 
       if (redirectCallback &&
           subscription.errors >= Prefs.subscriptions_fallbackerrors &&
           /^https?:\/\//i.test(subscription.url))
       {
         subscription.errors = 0;
 
         let fallbackURL = Prefs.subscriptions_fallbackurl;
         const {addonVersion} = require("info");

[kzar, 2017/10/18 15:12:08]

You missed this one.

[hub, 2017/10/18 17:57:45]

out of tree module

         fallbackURL = fallbackURL.replace(/%VERSION%/g,
                                           encodeURIComponent(addonVersion));
         fallbackURL = fallbackURL.replace(/%SUBSCRIPTION%/g,
                                           encodeURIComponent(subscription.url));
         fallbackURL = fallbackURL.replace(/%URL%/g,
                                           encodeURIComponent(downloadURL));
         fallbackURL = fallbackURL.replace(/%ERROR%/g,
                                           encodeURIComponent(error));
         fallbackURL = fallbackURL.replace(/%CHANNELSTATUS%/g,
                                           encodeURIComponent(channelStatus));
@@ skipping 27 matching lines @@
               subscription.filters.map(f => f.text).join("\n");
             redirectCallback("data:text/plain," + encodeURIComponent(data));
           }
         }, false);
         request.send(null);
       }
     }
   }
 };
 Synchronizer.init();