Issue 5762 - Use relative require paths

lib/filterListener.js

Index: lib/filterListener.js
===================================================================
--- a/lib/filterListener.js
+++ b/lib/filterListener.js
@@ -20,23 +20,23 @@
 /**
  * @fileOverview Component synchronizing filter storage with Matcher
  *               instances and ElemHide.
  */
 
 const {Services} = Cu.import("resource://gre/modules/Services.jsm", {});
 const {XPCOMUtils} = Cu.import("resource://gre/modules/XPCOMUtils.jsm", {});
 
-const {FilterStorage} = require("filterStorage");
-const {FilterNotifier} = require("filterNotifier");
-const {ElemHide} = require("elemHide");
-const {ElemHideEmulation} = require("elemHideEmulation");
-const {defaultMatcher} = require("matcher");
+const {FilterStorage} = require("./filterStorage");
+const {FilterNotifier} = require("./filterNotifier");
+const {ElemHide} = require("./elemHide");
+const {ElemHideEmulation} = require("./elemHideEmulation");
+const {defaultMatcher} = require("./matcher");
 const {ActiveFilter, RegExpFilter,
-       ElemHideBase, ElemHideEmulationFilter} = require("filterClasses");
+       ElemHideBase, ElemHideEmulationFilter} = require("./filterClasses");
 const {Prefs} = require("prefs");

[kzar, 2017/10/18 15:12:07]

You missed this one, I guess it should be "../../lib/prefs"

[hub, 2017/10/18 17:57:45]

I don't think it is a good idea to reference out of tree modules this way. This
will cause problems with testing of adblockpluscore since prefs.js is stubbed
during the tests, and ../../lib/prefs.js here leads nowhere since
adblockpluscore is checked out separately.

 
 /**
  * Increases on filter changes, filters will be saved if it exceeds 1.
  * @type {number}
  */
 let isDirty = 0;