Side by Side Diff: new-options.html
Issue 29556681:
Issue 5779 - Missing checkbox in language dialog and persistent validation (Closed)
Patch Set:
Created Sept. 26, 2017, 6:33 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
new-options.js » ('j')
|
skin/new-options.css » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 329 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 340 </span> | 340 </span> |
| 341 <button id="dialog-close" data-action="close-dialog"></button> | 341 <button id="dialog-close" data-action="close-dialog"></button> |
| 342 </header> | 342 </header> |
| 343 <div id="dialog-body" class="content"> | 343 <div id="dialog-body" class="content"> |
| 344 <!-- About Adblock Plus --> | 344 <!-- About Adblock Plus --> |
| 345 <div id="dialog-content-about" class="dialog-content"> | 345 <div id="dialog-content-about" class="dialog-content"> |
| 346 <p id="abp-version"></p> | 346 <p id="abp-version"></p> |
| 347 <p class="i18n_options_dialog_about_copyright"></p> | 347 <p class="i18n_options_dialog_about_copyright"></p> |
| 348 <p class="i18n_options_dialog_about_trademark"></p> | 348 <p class="i18n_options_dialog_about_trademark"></p> |
| 349 <p> | 349 <p> |
| 350 <button class="i18n_options_close primary" data-action="close-dialog "></button> | 350 <button class="i18n_options_close primary default-focus" data-action ="close-dialog"></button> |
|
saroyanm
2017/09/26 18:40:52
This dialogs were missing default focus, I thought
ire
2017/09/28 07:33:44
Acknowledged.
| |
| 351 </p> | 351 </p> |
| 352 </div> | 352 </div> |
| 353 <!-- Add language subscription --> | 353 <!-- Add language subscription --> |
| 354 <div id="dialog-content-language-add" class="dialog-content"> | 354 <div id="dialog-content-language-add" class="dialog-content"> |
| 355 <ul id="all-lang-table-add" class="table list"> | 355 <ul id="all-lang-table-add" class="table list default-focus"> |
| 356 <template> | 356 <template> |
| 357 <button data-action="add-language-subscription,close-dialog" class ="control add" role="checkbox"> | 357 <button data-action="add-language-subscription,close-dialog" class ="control add" role="checkbox"> |
| 358 <label class="display"></label> | 358 <label class="display"></label> |
| 359 </button> | 359 </button> |
| 360 <button data-action="change-language-subscription,close-dialog" cl ass="control change" role="checkbox"> | 360 <button data-action="change-language-subscription,close-dialog" cl ass="control change" role="checkbox"> |
| 361 <label class="display"></label> | 361 <label class="display"></label> |
| 362 </button> | 362 </button> |
| 363 </template> | 363 </template> |
| 364 </ul> | 364 </ul> |
| 365 </div> | 365 </div> |
| 366 <!-- Add import subscription --> | 366 <!-- Add import subscription --> |
| 367 <div id="dialog-content-import" class="dialog-content"> | 367 <div id="dialog-content-import" class="dialog-content"> |
| 368 <form data-validation="custom" novalidate> | 368 <form data-validation="custom" novalidate> |
| 369 <p class="floating-input"> | 369 <p class="floating-input"> |
| 370 <input placeholder=" " id="import-list-title" type="text" class="d efault-focus" required /> | 370 <input placeholder=" " id="import-list-title" type="text" class="d efault-focus" required /> |
| 371 <label for="import-list-title" class="i18n_options_dialog_import_s ubscription_title"></label> | 371 <label for="import-list-title" class="i18n_options_dialog_import_s ubscription_title"></label> |
| 372 <span class="attention"></span> | 372 <span class="attention"></span> |
| 373 <span class="i18n_options_dialog_import_subscription_title_error e rror-msg"></span> | 373 <span class="i18n_options_dialog_import_subscription_title_error e rror-msg"></span> |
| 374 </p> | 374 </p> |
| 375 <p class="floating-input"> | 375 <p class="floating-input"> |
| 376 <input placeholder=" " id="import-list-url" type="url" class="defa ult-focus" required/> | 376 <input placeholder=" " id="import-list-url" type="url" required/> |
| 377 <label for="import-list-url" class="i18n_options_dialog_import_sub scription_location"></label> | 377 <label for="import-list-url" class="i18n_options_dialog_import_sub scription_location"></label> |
| 378 <span class="attention"></span> | 378 <span class="attention"></span> |
| 379 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span> | 379 <span class="i18n_options_dialog_import_subscription_location_erro r error-msg"></span> |
| 380 </p> | 380 </p> |
| 381 <p class="side-controls"> | 381 <p class="side-controls"> |
| 382 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button> | 382 <button class="i18n_options_customFilter_cancel secondary" type="r eset" data-action="close-dialog"></button> |
| 383 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button> | 383 <button type="button" class="i18n_options_dialog_import_title prim ary" data-action="validate-import-subscription"></button> |
| 384 </p> | 384 </p> |
| 385 </form> | 385 </form> |
| 386 </div> | 386 </div> |
| (...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 419 </div> | 419 </div> |
| 420 <!-- Notification --> | 420 <!-- Notification --> |
| 421 <div id="notification" aria-hidden="true" aria-live="polite"> | 421 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 422 <strong id="notification-text"></strong> | 422 <strong id="notification-text"></strong> |
| 423 <button id="hide-notification" data-action="hide-notification"> | 423 <button id="hide-notification" data-action="hide-notification"> |
| 424 <span class="i18n_options_notification_hide sr-only"></span> | 424 <span class="i18n_options_notification_hide sr-only"></span> |
| 425 </button> | 425 </button> |
| 426 </div> | 426 </div> |
| 427 </body> | 427 </body> |
| 428 </html> | 428 </html> |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
new-options.js » ('j')
|
skin/new-options.css » ('J')
