Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: new-options.js

Issue 29556681: Issue 5779 - Missing checkbox in language dialog and persistent validation (Closed)
Patch Set: Created Sept. 26, 2017, 6:33 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 205 matching lines...) Expand 10 before | Expand all | Expand 10 after
216 continue; 216 continue;
217 217
218 let title = this._getItemTitle(item, i); 218 let title = this._getItemTitle(item, i);
219 let displays = element.querySelectorAll(".display"); 219 let displays = element.querySelectorAll(".display");
220 for (let j = 0; j < displays.length; j++) 220 for (let j = 0; j < displays.length; j++)
221 displays[j].textContent = title; 221 displays[j].textContent = title;
222 222
223 element.setAttribute("aria-label", title); 223 element.setAttribute("aria-label", title);
224 if (this.details[i].searchable) 224 if (this.details[i].searchable)
225 element.setAttribute("data-search", title.toLowerCase()); 225 element.setAttribute("data-search", title.toLowerCase());
226 let control = element.querySelector(".control[role='checkbox']"); 226 let controls = element.querySelectorAll(".control[role='checkbox']");
227 if (control) 227 for (let control of controls)
228 { 228 {
229 control.setAttribute("aria-checked", item.disabled == false); 229 control.setAttribute("aria-checked", item.disabled == false);
230 if (isAcceptableAds(item.url) && this == collections.filterLists) 230 if (isAcceptableAds(item.url) && this == collections.filterLists)
231 control.disabled = true; 231 control.disabled = true;
232 } 232 }
233 233
234 let lastUpdateElement = element.querySelector(".last-update"); 234 let lastUpdateElement = element.querySelector(".last-update");
235 if (lastUpdateElement) 235 if (lastUpdateElement)
236 { 236 {
237 let message = element.querySelector(".message"); 237 let message = element.querySelector(".message");
(...skipping 1143 matching lines...) Expand 10 before | Expand all | Expand 10 after
1381 }); 1381 });
1382 ext.backgroundPage.sendMessage({ 1382 ext.backgroundPage.sendMessage({
1383 type: "subscriptions.listen", 1383 type: "subscriptions.listen",
1384 filter: ["added", "disabled", "homepage", "lastDownload", "removed", 1384 filter: ["added", "disabled", "homepage", "lastDownload", "removed",
1385 "title", "downloadStatus", "downloading"] 1385 "title", "downloadStatus", "downloading"]
1386 }); 1386 });
1387 1387
1388 window.addEventListener("DOMContentLoaded", onDOMLoaded, false); 1388 window.addEventListener("DOMContentLoaded", onDOMLoaded, false);
1389 window.addEventListener("hashchange", onHashChange, false); 1389 window.addEventListener("hashchange", onHashChange, false);
1390 } 1390 }
OLDNEW

Powered by Google App Engine
This is Rietveld