Issue 5141 - Convert filter match to C++

compiled/StringMap.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 219 matching lines @@
 
     const_iterator end() const
     {
       return const_iterator(&mBuckets[mBucketCount], &mBuckets[mBucketCount]);
     }
 
     size_type size() const
     {
       return mEntryCount;
     }
+
+    void clear()
+    {
+      resize(0);

[sergei, 2017/10/02 12:02:33]

I'm not sure that `resize` expects a value, lower than the previous size, and
`find_bucket` does not expected `mBucketCount` to have zero value.

[sergei, 2017/10/04 08:54:31]

This is not addressed.

[sergei, 2017/10/06 09:33:56]

What about creation of an `init(size_type expectedEntries)` method and call it
from both the contructor and from `clear`?

[hub, 2017/10/06 13:49:16]

Done.

[hub, 2017/10/06 13:49:16]

that's the approach I took.

+    }
   };
 
   struct StringSetEntry
   {
     StringSetEntry() {}
     StringSetEntry(const String& key)
         : first(key)
     {
     }
 
@@ skipping 98 matching lines @@
   const_reference find(const String& key) const
   {
     return super::find(key);
   }
 
   reference find(const String& key)
   {
     return reference(this, key, super::find_bucket(key));
   }
 };