Issue 5141 - Convert filter match to C++

compiled/library.js

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 43 matching lines @@
   JSNotifySubscriptionChange: function(topic, subscription)
   {
     FilterNotifier.triggerListeners(notifierTopics.get(topic),
         exports.Subscription.fromPointer(subscription));
   },
 
   $_regexp_data: Object.create(null),
   $_regexp_counter: 0,
 
   GenerateRegExp__deps: ["$_regexp_data", "$_regexp_counter"],
-  GenerateRegExp: function(source, matchCase)
+  GenerateRegExp: function(source, matchCase, global)
   {
     var id = ++_regexp_counter;
     try
     {
-      _regexp_data[id] = new RegExp(readString(source), matchCase ? "" : "i");
+      var flag = matchCase ? "" : "i";
+      if (global)
+        flag += "g";
+      _regexp_data[id] = new RegExp(readString(source), flag);
       return id;
     }
     catch (e)
     {
       return -1;
     }
   },
 
   DeleteRegExp__deps: ["$_regexp_data"],
   DeleteRegExp: function(id)
   {
     delete _regexp_data[id];
   },
 
   TestRegExp__deps: ["$_regexp_data"],
   TestRegExp: function(id, str)
   {
     return _regexp_data[id].test(readString(str));
+  },
+
+  ExecRegExp__deps: ["$_regexp_data"],
+  ExecRegExp: function(id, str)
+  {
+    var match = _regexp_data[id].exec(readString(str));
+    if (match)
+      return match.index;
+    return -1;
+  },
+
+  MatchRegExp__deps: ["$_regexp_data"],
+  MatchRegExp: function(id, str, reMatchResults)
+  {
+    var string = readString(str);
+    var result = new exports.ReMatchResults(reMatchResults);
+    var matches = string.match(_regexp_data[id]);
+    if (!matches)
+      return false;
+    for (var i = 0; i < matches.length; i++)
+      result.push(createString(matches[i]));

[sergei, 2017/10/04 08:54:32]

matches[i] is JS String, but result.push expects our C++ const String&, so
createString should not be removed.

However, since the string is created on the stack, this method should contain
var sp = Runtime.stackSave(); at the beginning
and
Runtime.stackRestore(sp); before returning.

[hub, 2017/10/06 13:49:17]

No. push() argument is plain JS string. The bindings takes care of that:
````
exports.ReMatchResults = createClass(null, 0, {
push: function(arg0)
{
  var sp = Runtime.stackSave();
  __ZN14ReMatchResults4pushERK6String(this._pointer, createString(arg0));
  Runtime.stackRestore(sp);
},
});
````

Before: I had "empty" strings for the right count.
After: I get the right content.

[sergei, 2017/10/09 15:27:50]

Acknowledged.

+    return true;
   }
 });