Issue 5141 - Convert filter match to C++

compiled/String.cpp

+/*
+ * This file is part of Adblock Plus <https://adblockplus.org/>,
+ * Copyright (C) 2006-present eyeo GmbH
+ *
+ * Adblock Plus is free software: you can redistribute it and/or modify
+ * it under the terms of the GNU General Public License version 3 as
+ * published by the Free Software Foundation.
+ *
+ * Adblock Plus is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with Adblock Plus.  If not, see <http://www.gnu.org/licenses/>.
+ */
+
+
+#include "library.h"
+#include "String.h"
+
+OwnedString String::substr(size_type pos, size_type len) const
+{
+  if (len == npos)

[sergei, 2017/10/04 08:54:33]

I think this method should not contain that logic, it does not consider many
cases, like 'pos > length()', however `DependentString(const String& str,
size_type pos = 0, size_type len = npos)` already covers all such cases and
OwnedString can be constructed from it, so I think here simply
DependentString(*this, pos, len) should be returned. In addition, the return
type can be DependentString.

+  {
+    if (pos < length())
+      len = length() - pos;
+    else
+      len = 0;
+  }
+  return OwnedString(&mBuf[pos], len);
+}
+
+bool String::match(int id, ReMatchResults* results) const
+{
+  return MatchRegExp(id, *this, results);
+}