Issue 5141 - Convert filter match to C++

compiled/String.h

 /*
  * This file is part of Adblock Plus <https://adblockplus.org/>,
  * Copyright (C) 2006-present eyeo GmbH
  *
  * Adblock Plus is free software: you can redistribute it and/or modify
  * it under the terms of the GNU General Public License version 3 as
  * published by the Free Software Foundation.
  *
  * Adblock Plus is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 12 matching lines @@
 #include <type_traits>
 #include <vector>
 
 #include "debug.h"
 #include "library.h"
 #include "intrusive_ptr.h"
 #include "bindings/runtime.h"
 
 inline void String_assert_writable(bool isWritable);
 
-class OwnedString;
+class DependentString;
 class ReMatchResults;
 
 class String
 {
   friend class DependentString;
   friend class OwnedString;
 
 public:
   typedef char16_t value_type;
   typedef size_t size_type;
@@ skipping 147 matching lines @@
       // any performance difference.
       if (currChar >= u'A' && currChar <= u'Z')
         mBuf[i] = currChar + u'a' - u'A';
       else if (currChar >= 128)
       {
         mBuf[i] = CharToLower(currChar);
       }
     }
   }
 
-  OwnedString substr(size_type pos, size_type len = npos) const;
-  bool match(int id, ReMatchResults*) const;

[hub, 2017/09/26 21:48:59]

String API that mimic JS string API.

+  bool match(int id, ReMatchResults& results) const
+  {
+    return MatchRegExp(id, *this, results);
+  }

[Wladimir Palant, 2017/10/09 08:39:45]

This functionality doesn't belong here, it isn't basic String functionality. If
we need to share regexp-specific code between multiple classes, we should create
a new RegExp class for that.

[sergei, 2017/10/09 15:27:51]

I would suggest for the beginning simply remove the member function
`String::match` and use `MatchRegExp`.

 };
 
 class DependentString : public String
 {
 public:
   explicit DependentString()
       : String(nullptr, 0, INVALID)
   {
   }
 
@@ skipping 196 matching lines @@
 
     for (int i = size - 1; i >= 0; i--)
     {
       mBuf[pos + i] = '0' + (num % 10);
       num /= 10;
     }
   }
 };
 
 // Utility class to get match from JS code in library.js
 class ReMatchResults : public ref_counted

[hub, 2017/09/26 21:48:59]

This it the hack to be able to get the array of string that
`String::prototype::match()` returns, out of library.js.

[sergei, 2017/10/02 12:02:32]

I thin it's fine, I had experienced a demand in something like this too, so I
think we can accumulate some cases and then will see how to deal with it.

 {
 public:
-  void BINDINGS_EXPORTED push(OwnedString&& s)
-  {
-    candidates.push_back(s);
+  void BINDINGS_EXPORTED push(const String& s)
+  {
+    candidates.push_back(OwnedString(s));
   }
   std::vector<OwnedString> candidates;
-};
+};