Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: compiled/library.h

Issue 29556737: Issue 5141 - Convert filter match to C++ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/
Left Patch Set: Addressed most of the comment. Fixed some issues. Created Oct. 3, 2017, 7:31 p.m.
Right Patch Set: Fixed many issues. One test left out. Created Oct. 6, 2017, 1:45 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 /* 1 /*
2 * This file is part of Adblock Plus <https://adblockplus.org/>, 2 * This file is part of Adblock Plus <https://adblockplus.org/>,
3 * Copyright (C) 2006-present eyeo GmbH 3 * Copyright (C) 2006-present eyeo GmbH
4 * 4 *
5 * Adblock Plus is free software: you can redistribute it and/or modify 5 * Adblock Plus is free software: you can redistribute it and/or modify
6 * it under the terms of the GNU General Public License version 3 as 6 * it under the terms of the GNU General Public License version 3 as
7 * published by the Free Software Foundation. 7 * published by the Free Software Foundation.
8 * 8 *
9 * Adblock Plus is distributed in the hope that it will be useful, 9 * Adblock Plus is distributed in the hope that it will be useful,
10 * but WITHOUT ANY WARRANTY; without even the implied warranty of 10 * but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 24 matching lines...) Expand all
35 void LogError(const String& str); 35 void LogError(const String& str);
36 char16_t CharToLower(char16_t charCode); 36 char16_t CharToLower(char16_t charCode);
37 void JSNotifyFilterChange(FilterNotifier::Topic topic, Filter& filter, 37 void JSNotifyFilterChange(FilterNotifier::Topic topic, Filter& filter,
38 Subscription* subscription, unsigned int position); 38 Subscription* subscription, unsigned int position);
39 void JSNotifySubscriptionChange(FilterNotifier::Topic topic, 39 void JSNotifySubscriptionChange(FilterNotifier::Topic topic,
40 Subscription& subscription); 40 Subscription& subscription);
41 int GenerateRegExp(const String& regexp, bool matchCase, bool global); 41 int GenerateRegExp(const String& regexp, bool matchCase, bool global);
42 void DeleteRegExp(int id); 42 void DeleteRegExp(int id);
43 bool TestRegExp(int id, const String& str); 43 bool TestRegExp(int id, const String& str);
44 int ExecRegExp(int id, const String& str); 44 int ExecRegExp(int id, const String& str);
45 bool MatchRegExp(int id, const String& str, ReMatchResults* results); 45 bool MatchRegExp(int id, const String& str, ReMatchResults& results);
46 } 46 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld