compiled/StringMap.h - Issue 29556737: Issue 5141 - Convert filter match to C++

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: compiled/StringMap.h

Issue 29556737: Issue 5141 - Convert filter match to C++ (Closed) Base URL: https://hg.adblockplus.org/adblockpluscore/

Patch Set: Reworked the code, added test, they fail. Created Sept. 29, 2017, 4:01 p.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: compiled/StringMap.h

===================================================================

--- a/compiled/StringMap.h

+++ b/compiled/StringMap.h

@@ -232,16 +232,21 @@

{

return const_iterator(&mBuckets[mBucketCount], &mBuckets[mBucketCount]);

}

size_type size() const

{

return mEntryCount;

}

+ void clear()

+ {

+ resize(0);

+ }

};

struct StringSetEntry

{

StringSetEntry() {}

StringSetEntry(const String& key)

: first(key)

{

« no previous file with comments | « compiled/String.cpp ('k') | compiled/bindings/main.cpp » ('j') | no next file with comments »