Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29557565: Issue 5800 - Add option to specify a list of V8 libraries (Closed)
Left Patch Set: Created Sept. 27, 2017, 9:10 a.m.
Right Patch Set: moved 'packagingOptions' section to dynamic linking 'if' branch only Created Nov. 2, 2017, 11:30 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | libadblockplus-android/build.gradle » ('j') | libadblockplus-android/build.gradle » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Plus Library for Android 1 Adblock Plus Library for Android
2 ================================ 2 ================================
3 3
4 An Android library project, tests and demo application for AdblockWebView widget . 4 An Android library project, tests and demo application for AdblockWebView widget .
5 5
6 ## Updating the dependencies 6 ## Updating the dependencies
7 7
8 Adblock Plus for Android has dependencies that aren't in this repository. 8 Adblock Plus for Android has dependencies that aren't in this repository.
9 To update those, call: 9 To update those, call:
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 **Android permissions note** 86 **Android permissions note**
87 87
88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`: 88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`:
89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>` 89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>`
90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>` 90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>`
91 91
92 (added automatically if building with Gradle or should be added manually otherwi se). 92 (added automatically if building with Gradle or should be added manually otherwi se).
93 93
94 ### Building with prebuilt shared V8 94 ### Building with prebuilt shared V8
95 95
96 This can be desired to use product's V8 (let's say Chromium) instead of libadblo ckplus built-in V8. 96 This can be desired to use product's V8 (let's say Chromium) instead of built-in V8.
97 Put prebuilt shared V8 library file in ARCH directories and set `SHARED_V8_LIB_F ILENAME` 97 Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LI B_FILENAMES`
98 environment variable before building. Libadblockplus is required to be linked wi th that library file. 98 environment variable before building. You can pass multiple filenames, separated with space.
99 Libadblockplus is required to be linked with that library file(s).
99 100
100 For example (build with Gradle): 101 For example (build with Gradle):
101 102
102 SHARED_V8_LIB_FILENAME=libswev8.so ./gradlew clean assemble 103 SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble
103 104
104 Note `[Configuration] Linking dynamically with shared v8 library ./libadblockplu s-binaries/android_armeabi-v7a/libv8.cr.so` 105 or
105 output while building native library. 106
107 SHARED_V8_LIB_FILENAMES="libv8.cr.so libfoo.so" ./gradlew clean assemble
108
109 for multiple library files.
110
111 Note
112
113 [Configuration] Excluding shared v8 library libv8.cr.so from AAR
114 ...
115 [Configuration] Linking dynamically with shared v8 library ./libadblockplus- binaries/android_armeabi-v7a/libv8.cr.so
116 ...
117
118 output while building.
106 119
107 ## Library tests 120 ## Library tests
108 121
109 Android tests for the library. 122 Android tests for the library.
110 You can find them in the 'libadblockplus-android-tests' directory. 123 You can find them in the 'libadblockplus-android-tests' directory.
111 124
112 ### Requirements 125 ### Requirements
113 126
114 Make sure _Library_ requirements are present. 127 Make sure _Library_ requirements are present.
115 128
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
311 324
312 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry. 325 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry.
313 326
314 #### Building with Gradle 327 #### Building with Gradle
315 328
316 In the project root directory run: 329 In the project root directory run:
317 330
318 ./gradlew assemble 331 ./gradlew assemble
319 332
320 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory. 333 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld