Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: README.md

Issue 29557565: Issue 5800 - Add option to specify a list of V8 libraries (Closed)
Left Patch Set: Renamed env. variable Created Sept. 29, 2017, 8:27 a.m.
Right Patch Set: moved 'packagingOptions' section to dynamic linking 'if' branch only Created Nov. 2, 2017, 11:30 a.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « no previous file | libadblockplus-android/build.gradle » ('j') | libadblockplus-android/build.gradle » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 Adblock Plus Library for Android 1 Adblock Plus Library for Android
2 ================================ 2 ================================
3 3
4 An Android library project, tests and demo application for AdblockWebView widget . 4 An Android library project, tests and demo application for AdblockWebView widget .
5 5
6 ## Updating the dependencies 6 ## Updating the dependencies
7 7
8 Adblock Plus for Android has dependencies that aren't in this repository. 8 Adblock Plus for Android has dependencies that aren't in this repository.
9 To update those, call: 9 To update those, call:
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 **Android permissions note** 86 **Android permissions note**
87 87
88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`: 88 An app that uses the library have to add the following permissions to `AndroidMa nifest.xml`:
89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>` 89 * `<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE"/>`
90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>` 90 * `<uses-permission android:name="android.permission.ACCESS_WIFI_STATE"/>`
91 91
92 (added automatically if building with Gradle or should be added manually otherwi se). 92 (added automatically if building with Gradle or should be added manually otherwi se).
93 93
94 ### Building with prebuilt shared V8 94 ### Building with prebuilt shared V8
95 95
96 This can be desired to use product's V8 (let's say Chromium) instead of libadblo ckplus built-in V8. 96 This can be desired to use product's V8 (let's say Chromium) instead of built-in V8.
sergei 2017/09/29 08:35:41 I would replace "libadblockplus built-in V8" by "V
anton 2017/09/29 08:43:51 The user can be not aware of internal structure of
sergei 2017/09/29 09:21:05 OK, but V8 is not build-in, libadblockplus.a is no
anton 2017/09/29 11:45:28 Acknowledged.
97 Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LI B_FILENAMES` 97 Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LI B_FILENAMES`
98 environment variable before building. You can pass multiple filenames, separated with `:`. 98 environment variable before building. You can pass multiple filenames, separated with space.
sergei 2017/09/29 08:35:41 Why not separate them by spaces instead of `:`?
anton 2017/09/29 08:43:51 Does it make sense what separator? ":" standard s
sergei 2017/09/29 09:21:04 On windows the standard path separator is ; becaus
anton 2017/09/29 11:45:28 Let's have ',' as working for all solution.
99 Libadblockplus is required to be linked with that library file(s). 99 Libadblockplus is required to be linked with that library file(s).
sergei 2017/09/29 08:35:41 actually not "Libadblockplus" but libadblockplus-a
anton 2017/09/29 08:43:51 I've meant libadblockplus actually. To be more det
sergei 2017/09/29 09:21:04 Acknowledged. Maybe we should say that this librar
anton 2017/09/29 11:45:29 I'm not sure it's required for most users. And it
100 100
101 For example (build with Gradle): 101 For example (build with Gradle):
102 102
103 SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble 103 SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble
104 104
105 or 105 or
106 106
107 SHARED_V8_LIB_FILENAMES=libv8.cr.so:libfoo.so ./gradlew clean assemble 107 SHARED_V8_LIB_FILENAMES="libv8.cr.so libfoo.so" ./gradlew clean assemble
108 108
109 for multiple library files. 109 for multiple library files.
110 110
111 Note 111 Note
112 112
113 [Configuration] Excluding shared v8 library libv8.cr.so from AAR
114 ...
113 [Configuration] Linking dynamically with shared v8 library ./libadblockplus- binaries/android_armeabi-v7a/libv8.cr.so 115 [Configuration] Linking dynamically with shared v8 library ./libadblockplus- binaries/android_armeabi-v7a/libv8.cr.so
114 116 ...
115 output while building native library. 117
118 output while building.
116 119
117 ## Library tests 120 ## Library tests
118 121
119 Android tests for the library. 122 Android tests for the library.
120 You can find them in the 'libadblockplus-android-tests' directory. 123 You can find them in the 'libadblockplus-android-tests' directory.
121 124
122 ### Requirements 125 ### Requirements
123 126
124 Make sure _Library_ requirements are present. 127 Make sure _Library_ requirements are present.
125 128
(...skipping 195 matching lines...) Expand 10 before | Expand all | Expand 10 after
321 324
322 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry. 325 This will generate *.apk in the 'libadblockplus-android-webviewapp/bin/' directo ry.
323 326
324 #### Building with Gradle 327 #### Building with Gradle
325 328
326 In the project root directory run: 329 In the project root directory run:
327 330
328 ./gradlew assemble 331 ./gradlew assemble
329 332
330 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory. 333 This will generate *.apk in the 'libadblockplus-android-webviewapp/build/outputs /apk/' directory.
LEFTRIGHT

Powered by Google App Engine
This is Rietveld