Issue 5800 - Add option to specify a list of V8 libraries

README.md

Index: README.md
diff --git a/README.md b/README.md
index deb034f259aff3b9cb296db73abe1b8a96308ea1..d4068342969489f3a4b0fe40968dbd3eb5788e05 100644
--- a/README.md
+++ b/README.md
@@ -91,6 +91,29 @@ An app that uses the library have to add the following permissions to `AndroidMa
 
 (added automatically if building with Gradle or should be added manually otherwise).
 
+### Building with prebuilt shared V8
+
+This can be desired to use product's V8 (let's say Chromium) instead of libadblockplus built-in V8.

[sergei, 2017/09/29 08:35:41]

I would replace "libadblockplus built-in V8" by "V8 shipped with
libadblockplus-binaries".

[anton, 2017/09/29 08:43:51]

The user can be not aware of internal structure of our code
(core>libadblockplus>libadblockplus-android) so here "libadblockplus" is just "a
library that provides an opportunity to use Adblock Plus in 3rd party product".
I would leave it as-is.

[sergei, 2017/09/29 09:21:05]

OK, but V8 is not build-in, libadblockplus.a is not linked with any V8 yet,
maybe just remove the word "libadblockplus"?

[anton, 2017/09/29 11:45:28]

Acknowledged.

+Put prebuilt shared V8 library file(s) in ARCH directories and set `SHARED_V8_LIB_FILENAMES`
+environment variable before building. You can pass multiple filenames, separated with `:`.

[sergei, 2017/09/29 08:35:41]

Why not separate them by spaces instead of `:`?

[anton, 2017/09/29 08:43:51]

Does it make sense what separator?  ":" standard separator in PATHs and etc. if
it's not good for some reason then i'd prefer ",".

[sergei, 2017/09/29 09:21:04]

On windows the standard path separator is ; because paths contain :, e.g.
c:\projects\. We pass the libraries to the compiler separating them by spaces
and using quotes if there a space in the path or in a file name. Therefore I
think we should use spaces just don't support names with spaces which is likely
a very uncommon case.

[anton, 2017/09/29 11:45:28]

Let's have ',' as working for all solution.

+Libadblockplus is required to be linked with that library file(s).

[sergei, 2017/09/29 08:35:41]

actually not "Libadblockplus" but libadblockplus-android.so

[anton, 2017/09/29 08:43:51]

I've meant libadblockplus actually. To be more detailed i've meant
"libadblockplus-binaries linked with same dynamic libs".

[sergei, 2017/09/29 09:21:04]

Acknowledged. Maybe we should say that this library requires linking with V8?

[anton, 2017/09/29 11:45:29]

I'm not sure it's required for most users. And it seems to be obvious for
advanced users (who want's to link with their product like Chromium).

+
+For example (build with Gradle):
+
+    SHARED_V8_LIB_FILENAMES=libv8.cr.so ./gradlew clean assemble
+    
+or
+
+    SHARED_V8_LIB_FILENAMES=libv8.cr.so:libfoo.so ./gradlew clean assemble
+    
+for multiple library files.
+
+Note
+  
+    [Configuration] Linking dynamically with shared v8 library ./libadblockplus-binaries/android_armeabi-v7a/libv8.cr.so
+
+output while building native library. 
+
 ## Library tests
 
 Android tests for the library.