Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29557741: Issue 5773 - use ES6 for stylesheets and cssRules. (Closed)

Created:
Sept. 27, 2017, 11 p.m. by hub
Modified:
Sept. 28, 2017, 11:58 a.m.
Base URL:
https://hg.adblockplus.org/adblockpluscore/
Visibility:
Public.

Description

Issue 5773 - use ES6 for stylesheets and cssRules. Support for Chrome <51 will be polyfilled

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -8 lines) Patch
M lib/content/elemHideEmulation.js View 1 chunk +2 lines, -8 lines 0 comments Download

Messages

Total messages: 4
hub
Sept. 27, 2017, 11 p.m. (2017-09-27 23:00:41 UTC) #1
hub
With https://codereview.adblockplus.org/29557738/ in adblockpluschrome this should work on all the versions we support.
Sept. 27, 2017, 11:01 p.m. (2017-09-27 23:01:13 UTC) #2
Sebastian Noack
LGTM
Sept. 27, 2017, 11:09 p.m. (2017-09-27 23:09:10 UTC) #3
kzar
Sept. 28, 2017, 9:19 a.m. (2017-09-28 09:19:45 UTC) #4
I don't think codereview is necessary for reverting commits?

Powered by Google App Engine
This is Rietveld