Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29558607: Issue 5572 - fix stringBeginsWith in Util.cpp (Closed)

Created:
Sept. 28, 2017, 10:45 a.m. by sergei
Modified:
Sept. 28, 2017, 12:57 p.m.
Reviewers:
anton, diegocarloslima, jens
CC:
Felix Dahlke, René Jeschke
Base URL:
github.com:abby-sergz/libadblockplus-android.git
Visibility:
Public.

Description

COLLABORATOR=anton@adblockplus.org

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M libadblockplus-android/jni/Utils.cpp View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 3
sergei
https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-android/jni/Utils.cpp File libadblockplus-android/jni/Utils.cpp (right): https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-android/jni/Utils.cpp#newcode108 libadblockplus-android/jni/Utils.cpp:108: return string.compare(0, beginning.length(), beginning) == 0; It was a ...
Sept. 28, 2017, 10:49 a.m. (2017-09-28 10:49:39 UTC) #1
anton
On 2017/09/28 10:49:39, sergei wrote: > https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-android/jni/Utils.cpp > File libadblockplus-android/jni/Utils.cpp (right): > > https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-android/jni/Utils.cpp#newcode108 > ...
Sept. 28, 2017, 10:52 a.m. (2017-09-28 10:52:45 UTC) #2
diegocarloslima
Sept. 28, 2017, 12:03 p.m. (2017-09-28 12:03:45 UTC) #3
On 2017/09/28 10:52:45, anton wrote:
> On 2017/09/28 10:49:39, sergei wrote:
> >
>
https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-andr...
> > File libadblockplus-android/jni/Utils.cpp (right):
> > 
> >
>
https://codereview.adblockplus.org/29558607/diff/29558608/libadblockplus-andr...
> > libadblockplus-android/jni/Utils.cpp:108: return string.compare(0,
> > beginning.length(), beginning) == 0;
> > It was a stupid mistake and it was working sometimes because of race
> conditions.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld