libadblockplus-android/jni/Utils.cpp - Issue 29558607: Issue 5572 - fix stringBeginsWith in Util.cpp

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Unified Diff: libadblockplus-android/jni/Utils.cpp

Issue 29558607: Issue 5572 - fix stringBeginsWith in Util.cpp (Closed) Base URL: github.com:abby-sergz/libadblockplus-android.git

Patch Set: Created Sept. 28, 2017, 10:45 a.m.

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Index: libadblockplus-android/jni/Utils.cpp

diff --git a/libadblockplus-android/jni/Utils.cpp b/libadblockplus-android/jni/Utils.cpp

index 6e24d46229002e937d441e194c40ec773c7105da..124abfe44b6bd0322a278f0b52434a76103e6057 100644

--- a/libadblockplus-android/jni/Utils.cpp

+++ b/libadblockplus-android/jni/Utils.cpp

@@ -105,7 +105,7 @@ jstring JniStdStringToJava(JNIEnv* env, std::string str)

bool stringBeginsWith(const std::string& string, const std::string& beginning)

{

- return string.compare(0, beginning.length(), beginning);

+ return string.compare(0, beginning.length(), beginning) == 0;

sergei 2017/09/28 10:49:38 It was a stupid mistake and it was working sometim

}

jobject NewJniArrayList(JNIEnv* env)

« no previous file with comments | « no previous file | no next file » | no next file with comments »