Side by Side Diff: new-options.html
Issue 29558637:
Issue 5806 - Acceptable ads being added to the UI on load (Closed)
Patch Set:
Created Sept. 28, 2017, 4:29 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« no previous file
|
new-options.js » ('j')
|
no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| OLD | NEW |
|---|---|
| 1 <!DOCTYPE html> | 1 <!DOCTYPE html> |
| 2 <!-- | 2 <!-- |
| 3 - This file is part of Adblock Plus <https://adblockplus.org/>, | 3 - This file is part of Adblock Plus <https://adblockplus.org/>, |
| 4 - Copyright (C) 2006-present eyeo GmbH | 4 - Copyright (C) 2006-present eyeo GmbH |
| 5 - | 5 - |
| 6 - Adblock Plus is free software: you can redistribute it and/or modify | 6 - Adblock Plus is free software: you can redistribute it and/or modify |
| 7 - it under the terms of the GNU General Public License version 3 as | 7 - it under the terms of the GNU General Public License version 3 as |
| 8 - published by the Free Software Foundation. | 8 - published by the Free Software Foundation. |
| 9 - | 9 - |
| 10 - Adblock Plus is distributed in the hope that it will be useful, | 10 - Adblock Plus is distributed in the hope that it will be useful, |
| (...skipping 91 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 102 <p id="enable-aa-description" class="i18n_options_acceptableAds_ad s_description_1"></p> | 102 <p id="enable-aa-description" class="i18n_options_acceptableAds_ad s_description_1"></p> |
| 103 <p class="i18n_options_acceptableAds_ads_description_2"></p> | 103 <p class="i18n_options_acceptableAds_ads_description_2"></p> |
| 104 </div> | 104 </div> |
| 105 <div> | 105 <div> |
| 106 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="privacy"> | 106 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="privacy"> |
| 107 <label class="i18n_options_acceptableAds_privacy_label"></label> | 107 <label class="i18n_options_acceptableAds_privacy_label"></label> |
| 108 <p class="i18n_options_acceptableAds_privacy_description"></p> | 108 <p class="i18n_options_acceptableAds_privacy_description"></p> |
| 109 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification"></ p> | 109 <p id="dnt" class="i18n_options_acceptableAds_dnt_notification"></ p> |
| 110 </div> | 110 </div> |
| 111 <div> | 111 <div> |
| 112 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="none"> | 112 <input data-action="switch-acceptable-ads" type="radio" name="acce ptable-ads" value="none" checked> |
|
saroyanm
2017/09/28 16:31:12
We want to have default selected checkbox, otherwi
Thomas Greiner
2017/09/28 16:50:59
Makes sense but let's do it programmatically by ca
saroyanm
2017/09/28 17:04:02
I agree, done.
| |
| 113 <label class="i18n_options_acceptableAds_none_label"></label> | 113 <label class="i18n_options_acceptableAds_none_label"></label> |
| 114 </div> | 114 </div> |
| 115 </form> | 115 </form> |
| 116 </section> | 116 </section> |
| 117 <section class="cols"> | 117 <section class="cols"> |
| 118 <header> | 118 <header> |
| 119 <h2 class="i18n_options_language_header"></h2> | 119 <h2 class="i18n_options_language_header"></h2> |
| 120 <p class="i18n_options_language_description"></p> | 120 <p class="i18n_options_language_description"></p> |
| 121 </header> | 121 </header> |
| 122 <div id="blocking-languages"> | 122 <div id="blocking-languages"> |
| (...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 419 </div> | 419 </div> |
| 420 <!-- Notification --> | 420 <!-- Notification --> |
| 421 <div id="notification" aria-hidden="true" aria-live="polite"> | 421 <div id="notification" aria-hidden="true" aria-live="polite"> |
| 422 <strong id="notification-text"></strong> | 422 <strong id="notification-text"></strong> |
| 423 <button id="hide-notification" data-action="hide-notification"> | 423 <button id="hide-notification" data-action="hide-notification"> |
| 424 <span class="i18n_options_notification_hide sr-only"></span> | 424 <span class="i18n_options_notification_hide sr-only"></span> |
| 425 </button> | 425 </button> |
| 426 </div> | 426 </div> |
| 427 </body> | 427 </body> |
| 428 </html> | 428 </html> |
| OLD | NEW |
« no previous file with comments
|
« no previous file
|
new-options.js » ('j')
|
no next file with comments »
