 Issue 29558641:
  Issue 5740 - Implemented new abp.org footer styles  (Closed) 
  Base URL: https://bitbucket.org/adblockplus/adblockplus.org
    
  
    Issue 29558641:
  Issue 5740 - Implemented new abp.org footer styles  (Closed) 
  Base URL: https://bitbucket.org/adblockplus/adblockplus.org| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 /******************************************************************************* | 1 /******************************************************************************* | 
| 2 * Base styles | 2 * Base styles | 
| 3 ******************************************************************************/ | 3 ******************************************************************************/ | 
| 4 html { | 4 html { | 
| 5 color: #212121; | 5 color: #212121; | 
| 6 background-color: #fff; | 6 background-color: #fff; | 
| 7 font-family: sans-serif; | 7 font-family: sans-serif; | 
| 8 line-height: 1.5; } | 8 line-height: 1.5; } | 
| 9 | 9 | 
| 10 /** | 10 /** | 
| (...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 62 | 62 | 
| 63 /* - .column(s) within .row .reverse appear in reverse order | 63 /* - .column(s) within .row .reverse appear in reverse order | 
| 64 * - .column(s) within [dir=rtl] appear in reverse order respectively | 64 * - .column(s) within [dir=rtl] appear in reverse order respectively | 
| 65 */ | 65 */ | 
| 66 .column, | 66 .column, | 
| 67 [dir="rtl"] .reverse .column { | 67 [dir="rtl"] .reverse .column { | 
| 68 float: left; } | 68 float: left; } | 
| 69 | 69 | 
| 70 .row, | 70 .row, | 
| 71 .column { | 71 .column { | 
| 72 box-sizing: border-box: } | 72 box-sizing: border-box; } | 
| 
juliandoucette
2017/10/05 17:09:57
Oops! I fixed an issue here https://codereview.adb
 | |
| 73 | 73 | 
| 74 .reverse .column, | 74 .reverse .column, | 
| 75 [dir="rtl"] .column { | 75 [dir="rtl"] .column { | 
| 76 float: right; } | 76 float: right; } | 
| 77 | 77 | 
| 78 @media (min-width: 768px) { | 78 @media (min-width: 768px) { | 
| 79 .one-half, | 79 .one-half, | 
| 80 .one-fourth { | 80 .one-fourth { | 
| 81 width: 50%; } } | 81 width: 50%; } } | 
| 82 | 82 | 
| (...skipping 48 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 131 } | 131 } | 
| 132 | 132 | 
| 133 .sprite | 133 .sprite | 
| 134 { | 134 { | 
| 135 display: inline-block; | 135 display: inline-block; | 
| 136 font-size: 0px; /* fix for IE6 height bug */ | 136 font-size: 0px; /* fix for IE6 height bug */ | 
| 137 background-image: url(../img/sprite-main.png); | 137 background-image: url(../img/sprite-main.png); | 
| 138 background-repeat: no-repeat; | 138 background-repeat: no-repeat; | 
| 139 } | 139 } | 
| 140 | 140 | 
| 141 nav ul | |
| 
juliandoucette
2017/10/05 17:09:56
Note: Both the header and the footer contain navs.
 | |
| 142 { | |
| 143 list-style: none; | |
| 144 margin: 0; | |
| 145 padding: 0; | |
| 146 } | |
| 147 | |
| 148 nav a:link, nav a:visited | |
| 149 { | |
| 150 color: #7d7d7d; | |
| 151 text-decoration: none; | |
| 152 } | |
| 153 | |
| 154 nav a:hover | |
| 155 { | |
| 156 text-decoration: underline; | |
| 157 } | |
| 158 | |
| 159 header | 141 header | 
| 160 { | 142 { | 
| 161 display: block; | 143 display: block; | 
| 162 position: relative; | 144 position: relative; | 
| 163 background: white; | 145 background: white; | 
| 164 border: 1px solid #d9d9d9; | 146 border: 1px solid #d9d9d9; | 
| 165 border-top: none; | 147 border-top: none; | 
| 166 box-shadow: 1px 1px 0 0 #d9d9d9; | 148 box-shadow: 1px 1px 0 0 #d9d9d9; | 
| 167 z-index: 1; | 149 z-index: 1; | 
| 168 } | 150 } | 
| (...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 262 .toc ul ul | 244 .toc ul ul | 
| 263 { | 245 { | 
| 264 padding-left: 40px; | 246 padding-left: 40px; | 
| 265 } | 247 } | 
| 266 | 248 | 
| 267 .toc li | 249 .toc li | 
| 268 { | 250 { | 
| 269 margin: 4px 0; | 251 margin: 4px 0; | 
| 270 } | 252 } | 
| 271 | 253 | 
| 272 #footer-main | 254 #social-list ul | 
| 273 { | |
| 274 display: block; | |
| 275 background: white; | |
| 276 box-shadow: 0 -1px 0 0 #b5b4b0, 0 -2px 0 0 #e4e1dc; | |
| 277 padding: 0; | |
| 278 line-height: 1; | |
| 279 } | |
| 280 | |
| 281 #footer-main nav h1, #footer-main nav li | |
| 282 { | |
| 283 color: #444444; | |
| 284 border-bottom: 1px solid #dedede; | |
| 285 } | |
| 286 | |
| 287 #footer-main h1 | |
| 288 { | |
| 289 font-size: 16px; | |
| 290 margin-top: 0; | |
| 291 margin-bottom: 15px; | |
| 292 } | |
| 293 | |
| 294 #footer-main nav li | |
| 295 { | |
| 296 margin-bottom: 5px; | |
| 297 } | |
| 298 | |
| 299 #social-list | |
| 300 { | 255 { | 
| 301 list-style: none; | 256 list-style: none; | 
| 302 padding: 0; | 257 padding: 0; | 
| 303 margin: 0; | 258 margin: 0; | 
| 304 } | 259 } | 
| 305 | 260 | 
| 306 .social-entry | 261 .social-entry | 
| 307 { | 262 { | 
| 308 display: inline-block; | 263 display: inline-block; | 
| 309 margin: 0px 5px; | 264 margin: 0px 5px; | 
| (...skipping 65 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 375 | 330 | 
| 376 [dir="ltr"] .alert | 331 [dir="ltr"] .alert | 
| 377 { | 332 { | 
| 378 border-left: 5px solid #d14841; | 333 border-left: 5px solid #d14841; | 
| 379 } | 334 } | 
| 380 | 335 | 
| 381 [dir="rtl"] .alert | 336 [dir="rtl"] .alert | 
| 382 { | 337 { | 
| 383 border-right: 5px solid #d14841; | 338 border-right: 5px solid #d14841; | 
| 384 } | 339 } | 
| 340 | |
| 341 @media(max-width: 767px) | |
| 342 { | |
| 343 #site-footer .column | |
| 344 { | |
| 345 display: none; | |
| 346 } | |
| 347 | |
| 348 #site-footer #social-list | |
| 
juliandoucette
2017/10/05 17:09:56
This is suspicious.
 | |
| 349 { | |
| 350 display: block; | |
| 351 } | |
| 352 | |
| 353 #site-footer #social-list ul | |
| 354 { | |
| 355 margin: 0em 1em; | |
| 356 } | |
| 357 } | |
| 358 | |
| 359 #site-footer | |
| 
juliandoucette
2017/10/05 17:09:57
I should probably order and/or separate (comment)
 | |
| 360 { | |
| 361 margin-top: 2em; | |
| 362 padding: 2em 0em; | |
| 363 color: #ececec; | |
| 364 background-color: #292929; | |
| 365 overflow: auto; | |
| 366 } | |
| 367 | |
| 368 #site-footer h5 | |
| 369 { | |
| 370 color: #ececec; | |
| 371 font-size: 22px; | |
| 372 margin: 16px 0px 40px 0px; | |
| 373 } | |
| 374 | |
| 375 #site-footer h5::after | |
| 
juliandoucette
2017/10/05 17:09:57
Note: I took this from https://codereview.adblockp
 | |
| 376 { | |
| 377 content: ""; | |
| 378 display: block; | |
| 379 width: 30px; | |
| 380 height: 3px; | |
| 
juliandoucette
2017/10/05 17:09:57
This is probably too wide.
 | |
| 381 margin: 16px 0px 0px 0px; | |
| 382 border: none; | |
| 383 background-color: #ececec; | |
| 384 } | |
| 385 | |
| 386 #site-footer p | |
| 387 { | |
| 388 font-size: 18px; | |
| 389 } | |
| 390 | |
| 391 #site-footer li | |
| 392 { | |
| 393 list-style-type: none; | |
| 394 } | |
| 395 | |
| 396 #site-footer ul | |
| 397 { | |
| 398 padding: 0px; | |
| 399 } | |
| 400 | |
| 401 #site-footer a | |
| 402 { | |
| 403 font-size: 18px; | |
| 404 color: #ececec; | |
| 405 text-decoration: none; | |
| 406 } | |
| 407 | |
| 408 #site-footer a:hover, | |
| 409 #site-footer a:active, | |
| 410 #site-footer a:focus | |
| 411 { | |
| 412 color: #fff; | |
| 413 text-decoration: underline; | |
| 414 } | |
| 415 | |
| 416 #footer-legal | |
| 417 { | |
| 418 margin-top: 3em; | |
| 419 } | |
| 420 | |
| 421 #site-footer #copyright-notice, | |
| 422 #site-footer #copyright-notice a, | |
| 423 #legal-list a | |
| 424 { | |
| 425 font-size: 14px; | |
| 426 } | |
| 427 | |
| 428 @media(min-width: 768px) | |
| 429 { | |
| 430 #site-footer #copyright-notice, | |
| 431 #site-footer #copyright-notice a, | |
| 432 #legal-list a | |
| 433 { | |
| 434 font-size: 16px; | |
| 435 } | |
| 436 } | |
| 437 | |
| 438 #social-list li, | |
| 439 #legal-list li | |
| 440 { | |
| 441 display: block; | |
| 442 float: left; | |
| 443 } | |
| 444 | |
| 445 #social-list li | |
| 446 { | |
| 447 margin-right: 10px; | |
| 448 } | |
| 449 | |
| 450 [dir="rtl"] #social-list li | |
| 451 { | |
| 452 margin-left: 10px; | |
| 453 } | |
| 454 | |
| 455 #social-list img | |
| 456 { | |
| 457 height: 40px; | |
| 458 } | |
| 459 | |
| 460 #legal-list li::after | |
| 461 { | |
| 462 margin: 0px 5px; | |
| 463 content: "|" | |
| 464 } | |
| 465 | |
| 466 #legal-list li:last-of-type::after | |
| 467 { | |
| 468 content: none; | |
| 469 } | |
| 470 | |
| 471 @media(min-width: 1024px) | |
| 472 { | |
| 473 #copyright-notice | |
| 474 { | |
| 475 float: left; | |
| 476 } | |
| 477 | |
| 478 [dir="rtl"] #copyright-notice | |
| 479 { | |
| 480 float: right; | |
| 481 } | |
| 482 | |
| 483 #legal-list | |
| 484 { | |
| 485 float: right; | |
| 486 } | |
| 487 | |
| 488 [dir="rtl"] #legal-list | |
| 489 { | |
| 490 float: left; | |
| 491 } | |
| 492 } | |
| OLD | NEW |