Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/css/main.css

Issue 29558641: Issue 5740 - Implemented new abp.org footer styles (Closed) Base URL: https://bitbucket.org/adblockplus/adblockplus.org
Patch Set: Refactored Created Oct. 6, 2017, 12:47 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 /******************************************************************************* 1 /*******************************************************************************
2 * Base styles 2 * Base styles
3 ******************************************************************************/ 3 ******************************************************************************/
4 html { 4 html {
5 color: #212121; 5 color: #212121;
6 background-color: #fff; 6 background-color: #fff;
7 font-family: sans-serif; 7 font-family: sans-serif;
8 line-height: 1.5; } 8 line-height: 1.5; }
9 9
10 /** 10 /**
(...skipping 120 matching lines...) Expand 10 before | Expand all | Expand 10 after
131 } 131 }
132 132
133 .sprite 133 .sprite
134 { 134 {
135 display: inline-block; 135 display: inline-block;
136 font-size: 0px; /* fix for IE6 height bug */ 136 font-size: 0px; /* fix for IE6 height bug */
137 background-image: url(../img/sprite-main.png); 137 background-image: url(../img/sprite-main.png);
138 background-repeat: no-repeat; 138 background-repeat: no-repeat;
139 } 139 }
140 140
141 nav ul
142 {
143 list-style: none;
144 margin: 0;
145 padding: 0;
146 }
147
148 nav a:link, nav a:visited
149 {
150 color: #7d7d7d;
151 text-decoration: none;
152 }
153
154 nav a:hover
155 {
156 text-decoration: underline;
157 }
158
159 header 141 header
160 { 142 {
161 display: block; 143 display: block;
162 position: relative; 144 position: relative;
163 background: white; 145 background: white;
164 border: 1px solid #d9d9d9; 146 border: 1px solid #d9d9d9;
165 border-top: none; 147 border-top: none;
166 box-shadow: 1px 1px 0 0 #d9d9d9; 148 box-shadow: 1px 1px 0 0 #d9d9d9;
167 z-index: 1; 149 z-index: 1;
168 } 150 }
(...skipping 93 matching lines...) Expand 10 before | Expand all | Expand 10 after
262 .toc ul ul 244 .toc ul ul
263 { 245 {
264 padding-left: 40px; 246 padding-left: 40px;
265 } 247 }
266 248
267 .toc li 249 .toc li
268 { 250 {
269 margin: 4px 0; 251 margin: 4px 0;
270 } 252 }
271 253
272 #footer-main 254 #social-list ul
juliandoucette 2017/10/06 13:03:40 Forgot about this style :D - It should probably be
ire 2017/10/09 10:38:02 Acknowledged.
273 {
274 display: block;
275 background: white;
276 box-shadow: 0 -1px 0 0 #b5b4b0, 0 -2px 0 0 #e4e1dc;
277 padding: 0;
278 line-height: 1;
279 }
280
281 #footer-main nav h1, #footer-main nav li
282 {
283 color: #444444;
284 border-bottom: 1px solid #dedede;
285 }
286
287 #footer-main h1
288 {
289 font-size: 16px;
290 margin-top: 0;
291 margin-bottom: 15px;
292 }
293
294 #footer-main nav li
295 {
296 margin-bottom: 5px;
297 }
298
299 #social-list
300 { 255 {
301 list-style: none; 256 list-style: none;
302 padding: 0; 257 padding: 0;
303 margin: 0; 258 margin: 0;
304 } 259 }
305 260
306 .social-entry
307 {
308 display: inline-block;
309 margin: 0px 5px;
310 }
311
312 .social-entry a
313 {
314 width: 82px;
315 height: 82px;
316 -webkit-transition: opacity .5s ease;
317 -moz-transition: opacity .5s ease;
318 -ms-transition: opacity .5s ease;
319 -o-transition: opacity .5s ease;
320 transition: opacity .5s ease;
321 opacity: .6;
322 }
323
324 .social-entry a:hover
325 {
326 opacity: 1.0;
327 }
328
329 #social-facebook
330 {
331 background-position: 0px 0px;
332 }
333
334 #social-twitter
335 {
336 background-position: 0px -83px;
337 }
338
339 #social-gplus
340 {
341 background-position: -83px 0px;
342 }
343
344 div.animation[started="false"]:before 261 div.animation[started="false"]:before
345 { 262 {
346 content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA8AAAAPBAMAAADJ%2B Ih5AAAAFVBMVEUAgAAAgAD%2F%2F%2F%2Fr9uvY7Ni%2B376h0aGeNpcsAAAAAXRSTlNtc%2BXFgwAAA DVJREFUeF5dzVEKACAMAlC7QW6t%2F7r%2FIYOBEPr1GOgw2AHiduaHkwKXwBK4BYZdylrpy4K%2BP%2 Fu5C1CVKVSzAAAAAElFTkSuQmCC); 263 content: url(data:image/png;base64,iVBORw0KGgoAAAANSUhEUgAAAA8AAAAPBAMAAADJ%2B Ih5AAAAFVBMVEUAgAAAgAD%2F%2F%2F%2Fr9uvY7Ni%2B376h0aGeNpcsAAAAAXRSTlNtc%2BXFgwAAA DVJREFUeF5dzVEKACAMAlC7QW6t%2F7r%2FIYOBEPr1GOgw2AHiduaHkwKXwBK4BYZdylrpy4K%2BP%2 Fu5C1CVKVSzAAAAAElFTkSuQmCC);
347 padding-left: 0px; 264 padding-left: 0px;
348 padding-right: 3px; 265 padding-right: 3px;
349 } 266 }
350 267
351 html[dir="rtl"] div.animation[started="false"]:before 268 html[dir="rtl"] div.animation[started="false"]:before
352 { 269 {
353 padding-left: 3px; 270 padding-left: 3px;
(...skipping 21 matching lines...) Expand all
375 292
376 [dir="ltr"] .alert 293 [dir="ltr"] .alert
377 { 294 {
378 border-left: 5px solid #d14841; 295 border-left: 5px solid #d14841;
379 } 296 }
380 297
381 [dir="rtl"] .alert 298 [dir="rtl"] .alert
382 { 299 {
383 border-right: 5px solid #d14841; 300 border-right: 5px solid #d14841;
384 } 301 }
302
303 /*******************************************************************************
juliandoucette 2017/10/06 13:03:40 What do you think of this comment style? /** * C
ire 2017/10/09 10:38:03 I don't mind it being used for subcategories, but
juliandoucette 2017/10/09 16:44:12 That's what I meant by "(except lines are 80 char
ire 2017/10/09 17:01:13 Oh alright. I thought you meant literally what you
304 * #site-footer
305 ******************************************************************************/
306
307 #site-footer
308 {
309 overflow: auto;
310 margin-top: 2em;
311 padding-top: 2em;
312 padding-bottom: 2em;
313 color: #ececec;
314 background-color: #292929;
315 font-size: 0.9em;
316 }
317
318 /* #site-footer body
319 ******************************************************************************/
320
321 #site-footer h5::after
ire 2017/10/09 10:38:03 This should be `:after`
juliandoucette 2017/10/11 13:12:06 Done.
322 {
323 content: "";
324 display: block;
325 width: 1.25em;
326 height: 3px;
ire 2017/10/09 10:38:03 If the width changes with the font size, I think t
juliandoucette 2017/10/11 13:12:07 Good point. Done.
327 margin: 1em 0em 0em 0em;
ire 2017/10/09 10:38:02 NIT: I don't think you need to set the margins for
juliandoucette 2017/10/11 13:12:06 Done.
328 border: none;
ire 2017/10/09 10:38:02 I don't think this style is needed. There isn't a
juliandoucette 2017/10/11 13:12:06 Acknowledged.
329 background-color: #ececec;
330 }
331
332 #site-footer li
333 {
334 list-style-type: none;
ire 2017/10/09 10:38:02 NIT: I don't know if it makes a difference, but I
juliandoucette 2017/10/11 13:12:07 Acknowledged. Never thought about this.
335 }
336
337 #site-footer ul
338 {
339 padding: 0px;
340 }
341
342 #site-footer a
343 {
344 color: #ececec;
345 text-decoration: none;
346 }
347
348 #site-footer a:hover,
349 #site-footer a:active,
350 #site-footer a:focus
351 {
352 color: #fff;
353 text-decoration: underline;
354 }
355
356 /* #site-footer #social-list
357 ******************************************************************************/
358
359 #social-list li
ire 2017/10/09 10:38:03 I think your trick of using negative margins on th
juliandoucette 2017/10/11 13:12:06 Yep. Done.
360 {
361 display: block;
362 float: left;
363 }
364
365 [dir="rtl"] #social-list li
366 {
367 float: right;
368 }
369
370 #social-list li
371 {
372 margin-right: 0.5em;
373 }
374
375 [dir="rtl"] #social-list li
376 {
377 margin-left: 0.5em;
378 }
379
380 #social-list img
381 {
382 height: 2em;
383 }
384
385 /* #site-footer #footer-legal
386 ******************************************************************************/
387
388 #footer-legal
389 {
390 overflow: auto;
ire 2017/10/09 10:38:03 NIT: I was a bit confused about why this style was
juliandoucette 2017/10/11 13:12:07 There is no good reason for this.
391 margin-top: 2em;
392 font-size: 0.8em;
393 }
394
395 /* #site-footer #footer-legal #legal-list
396 ******************************************************************************/
397
398 #legal-list li
399 {
400 display: block;
401 float: left;
402 }
403
404 [dir="rtl"] #legal-list li
405 {
406 float: right;
407 }
408
409 #legal-list li::after
410 {
411 margin-left: 0.25em;
412 margin-right: 0.25em;
ire 2017/10/09 10:38:02 Since the margin i sonly applied to the `::after`
juliandoucette 2017/10/11 13:12:06 Good point.
413 content: "|"
414 }
415
416 #legal-list li:last-of-type::after
417 {
418 content: none;
419 }
420
juliandoucette 2017/10/06 13:03:40 Maybe I should put a #site-footer comment here?
ire 2017/10/09 10:38:03 Sure. Or you can group all the `#site-footer #foot
421 /* float copyright and legal links left and right on ~desktop */
422 @media(min-width: 1200px)
423 {
424 #copyright-notice
425 {
426 float: left;
427 }
428
429 [dir="rtl"] #copyright-notice
430 {
431 float: right;
432 }
433
434 #legal-list
435 {
436 float: right;
437 }
438
439 [dir="rtl"] #legal-list
440 {
441 float: left;
442 }
443 }
444
juliandoucette 2017/10/06 13:03:40 Maybe I should move this up? e.g. under #site-foot
445 /* hide all footer links except #social-list on ~mobile */
446 @media(max-width: 767px)
447 {
448 #site-footer .column
449 {
450 display: none;
451 }
452
453 /* overriding display:none above */
454 #site-footer #social-list
455 {
456 display: block;
457 }
458 }
OLDNEW

Powered by Google App Engine
This is Rietveld