Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Issue 29559597: Issue 5810 - Use "specialization" as Subscription display title (Closed)

Created:
Sept. 29, 2017, 11:18 a.m. by anton
Modified:
Oct. 4, 2017, 8:55 a.m.
Reviewers:
diegocarloslima, jens
CC:
René Jeschke, Felix Dahlke, sergei
Visibility:
Public.

Description

Issue 5810 - Use "specialization" as Subscription display title In attachments to https://issues.adblockplus.org/ticket/5810 you can see how it was and became (screenshots).

Patch Set 1 #

Total comments: 2

Patch Set 2 : fix #

Messages

Total messages: 5
anton
Sept. 29, 2017, 11:20 a.m. (2017-09-29 11:20:45 UTC) #1
diegocarloslima
https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java (right): https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java#newcode212 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java:212: editor.putString(getSubscriptionSpecializationKey(i), eachSubscription.url); Shouldn't it be `eachSubscription.specialization` here?
Sept. 29, 2017, 2:27 p.m. (2017-09-29 14:27:20 UTC) #2
anton
Patchset uploaded https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java File libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java (right): https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java#newcode212 libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java:212: editor.putString(getSubscriptionSpecializationKey(i), eachSubscription.url); On 2017/09/29 14:27:20, diegocarloslima wrote: ...
Sept. 29, 2017, 8:39 p.m. (2017-09-29 20:39:35 UTC) #3
diegocarloslima
On 2017/09/29 20:39:35, anton wrote: > Patchset uploaded > > https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java > File > libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java ...
Sept. 29, 2017, 9:29 p.m. (2017-09-29 21:29:37 UTC) #4
jens
Oct. 4, 2017, 8:52 a.m. (2017-10-04 08:52:33 UTC) #5
On 2017/09/29 21:29:37, diegocarloslima wrote:
> On 2017/09/29 20:39:35, anton wrote:
> > Patchset uploaded
> > 
> >
>
https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-andr...
> > File
> >
>
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java
> > (right):
> > 
> >
>
https://codereview.adblockplus.org/29559597/diff/29559616/libadblockplus-andr...
> >
>
libadblockplus-android-settings/src/org/adblockplus/libadblockplus/android/settings/SharedPrefsStorage.java:212:
> > editor.putString(getSubscriptionSpecializationKey(i), eachSubscription.url);
> > On 2017/09/29 14:27:20, diegocarloslima wrote:
> > > Shouldn't it be `eachSubscription.specialization` here?
> > 
> > Yes, sure. Silly mistake.
> 
> LGTM

LGTM

Powered by Google App Engine
This is Rietveld