Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: static/scss/components/_select.scss

Issue 29559620: Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rebased Created Oct. 11, 2017, 5:20 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 34 matching lines...) Expand 10 before | Expand all | Expand 10 after
45 bottom: 100%; 45 bottom: 100%;
46 left: 0px; 46 left: 0px;
47 margin-bottom: 0.5em; 47 margin-bottom: 0.5em;
48 padding: 0.7em; 48 padding: 0.7em;
49 border: 1px solid $gray-medium; 49 border: 1px solid $gray-medium;
50 border-radius: 4px; 50 border-radius: 4px;
51 box-shadow: 0px 0px 10px 0px rgba(0, 0, 0, 0.3); 51 box-shadow: 0px 0px 10px 0px rgba(0, 0, 0, 0.3);
52 color: $black; 52 color: $black;
53 background: $white; 53 background: $white;
54 list-style: none; 54 list-style: none;
55 z-index: 2;
55 56
56 a 57 a
57 { 58 {
58 color: $black; 59 color: $black;
59 } 60 }
60 } 61 }
61 62
62 .custom-select-options[aria-hidden="true"] 63 .custom-select-options[aria-hidden="true"]
63 { 64 {
64 display: none; 65 display: none;
(...skipping 30 matching lines...) Expand all
95 li:last-child:after 96 li:last-child:after
96 { 97 {
97 content: none; 98 content: none;
98 } 99 }
99 100
100 a 101 a
101 { 102 {
102 color: inherit; 103 color: inherit;
103 } 104 }
104 } 105 }
106
107 // Custom Dropdown (extends the custom select element)
108
109 .custom-select-dropdown img
juliandoucette 2017/10/13 13:39:57 NIT: I think this image is supposed to be larger?
ire 2017/10/17 15:03:35 I think you're right. I would like to change this:
juliandoucette 2017/10/18 15:04:11 Acknowledged.
110 {
111 @extend .heading-icon;
112 }
113
114 .custom-select-dropdown .custom-select-selected,
115 .custom-select-dropdown .custom-select-options
116 {
117 width: 100%;
118 }
119
120 .custom-select-dropdown .custom-select-selected
121 {
122 position: relative;
123 height: 40px;
juliandoucette 2017/10/13 13:39:57 NIT: It's inconsistent to mix px and em here
ire 2017/10/17 15:03:35 Done.
124 padding-right: 2.5em;
125 color: $primary;
126 text-align: left;
127 }
128
129 [dir="rtl"] .custom-select-dropdown .custom-select-selected
130 {
131 padding-right: 0.7em;
132 padding-left: 2.5em;
133 text-align: right;
134 }
135
136 .custom-select-dropdown .custom-select-selected:after
137 {
138 position: absolute;
139 top: 0;
140 right: 0;
141 width: 2em;
juliandoucette 2017/10/13 13:39:57 NIT: This looks wider in the mockups? 3em? (one wi
ire 2017/10/17 15:03:35 Done.
142 height: 100%;
143 border-left: 2px solid $gray-medium;
juliandoucette 2017/10/13 13:39:57 NIT: This looks like 1px in the mockups? (The same
ire 2017/10/17 15:03:35 We changed it to 2px because you said it was too t
144 background-image: url(/img/png/arrow-down-icon-secondary.png);
juliandoucette 2017/10/13 13:39:56 NIT: Can we use SVG or 2x PNG and fallback to 1x p
ire 2017/10/17 15:03:35 I know it's possible to set multiple background-im
juliandoucette 2017/10/18 15:04:11 https://css-tricks.com/svg-fallbacks/#article-head
ire 2017/10/20 13:40:48 Neat! Done.
145 background-repeat: no-repeat;
146 background-position: center;
147 background-size: 0.7em;
148 content: "";
149 }
150
151 [dir="rtl"] .custom-select-dropdown .custom-select-selected:after
152 {
153 right: auto;
154 left: 0;
155 border-right: 2px solid $gray-medium;
156 border-left: 0;
157 }
158
159 .custom-select-dropdown .custom-select-options
160 {
161 top: 100%;
162 bottom: auto;
163 }
164
165 .custom-select-dropdown .custom-select-options li
166 {
167 line-height: 40px;
juliandoucette 2017/10/13 13:39:56 NIT: It's inconsistent to mix px and em here
ire 2017/10/17 15:03:35 Done.
168 }
OLDNEW

Powered by Google App Engine
This is Rietveld