Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Side by Side Diff: includes/browser-select.tmpl

Issue 29559620: Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Remove test class names from body Created Oct. 23, 2017, 4:14 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1
juliandoucette 2017/10/24 12:12:27 Suggest: <fieldset>?
ire 2017/10/27 10:22:56 Done.
2 <label id="browser-select-label">
3 {{ "Your Browser" | translate("browser-select-label", "Label") }}:
4 </label>
5
6 <div id="browser-select" class="custom-select custom-select-dropdown">
7 <button class="custom-select-selected" aria-expanded="false" aria-haspopup="tr ue">
8 </button>
9 <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby="b rowser-select-label">
10 {% for browser in browsers %}
11 <li class="custom-select-option" role="menuitemradio" aria-checked="false" t abindex="0" data-value="{{ browser.id }}">
12 <img src="/img/png/logo-abp.png" srcset="/img/svg/logo-abp.svg 2x">
juliandoucette 2017/10/24 12:12:27 NIT: Missing alt text
ire 2017/10/27 10:22:56 Done.
13 {{ browser.name | translate(browser.id + "-name") }}
14 </li>
15 {% endfor %}
16 </ul>
17 </div>
18
19 <script id="browser-select-autodetected" type="text/template">{{ "autodetected" | translate("browser-select-autodetected") }}</script>
OLDNEW

Powered by Google App Engine
This is Rietveld