 Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Left: | ||
| Right: | 
| OLD | NEW | 
|---|---|
| 1 {% extends "templates/default" %} | 1 {% extends "templates/default" %} | 
| 2 | 2 | 
| 3 {% set product = products[product_id] %} | 3 {% set product = products[product_id] %} | 
| 4 | 4 | 
| 5 {% block body %} | 5 {% block body %} | 
| 6 [Breadcrumbs] | 6 [Breadcrumbs] | 
| 7 | 7 | 
| 8 <main id="main" class="container clearfix"> | 8 <main id="main" class="container clearfix"> | 
| 9 <article class="article card {{ product_id }}-card section column two-thirds"> | 9 <article class="article card {{ product_id }}-card section column two-thirds"> | 
| 10 <h1 class="article-heading"> | 10 <h1 class="article-heading"> | 
| 11 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> | 11 <img class="heading-icon" src="/img/png/logo-{{ product_id }}.png" srcse t="/img/svg/logo-{{ product_id }}.svg 2x" alt="{{ product.full_name+" Logo" | tr anslate( product_id+"-logo-alt", "Image alt text") }}"> | 
| 12 | 12 | 
| 13 {{ title | translate( get_page_name(page) + "-title", "Article title") } } | 13 {{ title | translate( get_page_name(page) + "-title", "Article title") } } | 
| 14 </h1> | 14 </h1> | 
| 15 | 15 | 
| 16 {% if hide_browser_selector is not defined %} | 16 {% if hide_browser_selector is not defined %} | 
| 17 <div class="article-browser-selector"> | 17 <div class="article-browser-selector clearfix"> | 
| 
juliandoucette
2017/10/24 12:12:30
NIT: Why not @extend .clearfix?
 
ire
2017/10/27 10:22:59
Done.
 | |
| 18 [Browser selector] | 18 <? include browser-select ?> | 
| 19 </div> | 19 </div> | 
| 20 {% endif %} | 20 {% endif %} | 
| 21 | 21 | 
| 22 <div class="article-body content"> | 22 <div class="article-body content"> | 
| 23 {{ body | safe }} | 23 {{ body | safe }} | 
| 24 </div> | 24 </div> | 
| 25 </article> | 25 </article> | 
| 26 <aside class="section column one-third"> | 26 <aside class="section column one-third"> | 
| 27 <? include product-topics-accordion ?> | 27 <? include product-topics-accordion ?> | 
| 28 </aside> | 28 </aside> | 
| 29 </main> | 29 </main> | 
| 30 | 30 | 
| 31 <script id="no-content-for-platform-message" type="text/template"> | 31 <script id="no-content-for-platform-message" type="text/template"> | 
| 32 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> | 32 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> | 
| 33 </script> | 33 </script> | 
| 34 | |
| 35 <script src="/js/vendor/bowser.js"></script> | |
| 34 {% endblock %} | 36 {% endblock %} | 
| OLD | NEW |