Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: includes/browser-select.tmpl

Issue 29559620: Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Created Sept. 29, 2017, 12:02 p.m.
Right Patch Set: Re-add browser-select include, add scripts block Created Nov. 2, 2017, 2:29 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
LEFTRIGHT
1 <fieldset>
2 <label id="browser-select-label">
3 {{ "Your Browser" | translate("browser-select-label", "Label") }}:
4 </label>
1 5
2 <label id="browser-select-label"> 6 <div id="browser-select" class="custom-select custom-select-dropdown">
3 Your Browser: 7 <button class="custom-select-selected" aria-expanded="false" aria-haspopup=" true">
4 </label> 8 </button>
9 <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby= "browser-select-label">
10 {% for browser in browsers %}
11 <li class="custom-select-option" role="menuitemradio" aria-checked="false" tabindex="0" data-value="{{ browser.id }}">
12 <span class="has-pre-icon">
13 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}" ></span>
14 {{ browser.name | translate(browser.id + "-name") }}
15 </span>
16 </li>
17 {% endfor %}
18 </ul>
19 </div>
20 </fieldset>
5 21
6 <div id="browser-select" class="custom-select custom-select-dropdown"> 22 <script id="browser-select-autodetected" type="text/template">{{ "autodetected" | translate("browser-select-autodetected") }}</script>
7 <button class="custom-select-selected" aria-expanded="false" aria-haspopup="tr ue">
8 </button>
9 <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby="b rowser-select-label">
10 {% for browser in browsers %}
11 <li class="custom-select-option" role="button" tabindex="0" data-value="{{br owser.id}}">
12 <img src="/img/png/logo-abp.png" srcset="/img/svg/logo-abp.svg 2x">
ire 2017/09/29 12:13:24 Also, forgot to mention I have been using the ABP
13 {{browser.name}}
14 </li>
15 {% endfor %}
16 </ul>
17 </div>
18
LEFTRIGHT

Powered by Google App Engine
This is Rietveld