Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com

static/scss/components/_browser-select.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
 // MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
 // GNU General Public License for more details.
 //
 // You should have received a copy of the GNU General Public License
 // along with help.eyeo.com.  If not, see <http://www.gnu.org/licenses/>.
 
 #browser-select-label
-{
+{  
+  margin-right: 1em;
   text-transform: uppercase;
-  margin-right: $md;

[juliandoucette, 2017/10/13 13:39:56]

NIT/Suggest: 1em?

[ire, 2017/10/17 15:03:34]

Done.

 }
 
 [dir="rtl"] #browser-select-label
 {
   margin-right: auto;

[juliandoucette, 2017/10/13 13:39:56]

SuperNIT: Shorthand margin would be shorter.

[ire, 2017/10/17 15:03:34]

(Same answer I gave in the other review about being an overriding thing)

[juliandoucette, 2017/10/18 15:04:11]

Acknowledged.

-  margin-left: $md;
+  margin-left: 1em;
 }
 
 #browser-select

[juliandoucette, 2017/10/13 13:39:56]

NIT: If you use the floating box model then you won't have to deal with the
extra whitespace. Especially on small screens (if this dropdown breaks to the
next line).

[ire, 2017/10/17 15:03:34]

Sorry, extra space where? When this moves onto its own line it should 100% width

[juliandoucette, 2017/10/18 15:04:11]

No idea :/ . Doesn't seem to be an issue to me. Sorry.

[ire, 2017/10/20 13:40:48]

No problem :)

 {
+  display: inline-block;
   width: 100%;
   max-width: 300px;
-  display: inline-block;
 }
 
 #browser-select li
 {
   cursor: pointer;
 }