Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com

static/scss/components/_select.scss

 // This file is part of help.eyeo.com.
 // Copyright (C) 2017 Eyeo GmbH
 //
 // help.eyeo.com is free software: you can redistribute it and/or modify
 // it under the terms of the GNU General Public License as published by
 // the Free Software Foundation, either version 3 of the License, or
 // (at your option) any later version.
 //
 // help.eyeo.com is distributed in the hope that it will be useful,
 // but WITHOUT ANY WARRANTY; without even the implied warranty of
@@ skipping 27 matching lines @@
 {
   display: inline-block;
 }
 
 .custom-select-options
 {
   position: absolute;
   bottom: 100%;
   left: 0px;
   margin-bottom: 0.5em;
-  padding: 0.7em;
   border: 1px solid $gray-medium;
   border-radius: 4px;
   box-shadow: 0px 0px 10px 0px rgba(0, 0, 0, 0.3);
   color: $black;
   background: $white;
   list-style: none;
   z-index: 2;
 
   a
   {
@@ skipping 38 matching lines @@
   {
     content: none;
   }
 
   a
   {
     color: inherit;
   }
 }
 
+.custom-select-option

[juliandoucette, 2017/11/02 15:22:19]

suggest: change background-color on hove/active/focus of select and options

[ire, 2017/11/03 08:45:36]

I'll probably handle this in the other issue handling hover/active/focus state
for the accordion

+{
+  padding: 0.7em;
+}
+
 // Custom Dropdown (extends the custom select element)

[juliandoucette, 2017/11/02 15:22:18]

suggest: category comment (underline it)

[ire, 2017/11/03 08:45:36]

Will change all comments in a separate issue

-
-.custom-select-dropdown img

[juliandoucette, 2017/10/13 13:39:57]

NIT: I think this image is supposed to be larger?

[ire, 2017/10/17 15:03:35]

I think you're right. I would like to change this: 1. When I have the correct
icons and/or 2: During the issue about fixing alignment for the .heading-icon 

[juliandoucette, 2017/10/18 15:04:11]

Acknowledged.

-{
-  @extend .heading-icon;
-}
 
 .custom-select-dropdown .custom-select-selected,
 .custom-select-dropdown .custom-select-options
 {
   width: 100%;
 }
 
 .custom-select-dropdown .custom-select-selected
 {
   position: relative;
-  height: 40px;

[juliandoucette, 2017/10/13 13:39:57]

NIT: It's inconsistent to mix px and em here

[ire, 2017/10/17 15:03:35]

Done.

-  padding-right: 2.5em;
+  height: 2.5em;
+  padding-right: 3.5em;
+  padding-left: 0.7em;
   color: $primary;
   text-align: left;
 }
 
 [dir="rtl"] .custom-select-dropdown .custom-select-selected
 {
   padding-right: 0.7em;
-  padding-left: 2.5em;
+  padding-left: 3.5em;
   text-align: right;
 }
 
 .custom-select-dropdown .custom-select-selected:after
 {
   position: absolute;
   top: 0;
   right: 0;
-  width: 2em;

[juliandoucette, 2017/10/13 13:39:57]

NIT: This looks wider in the mockups? 3em? (one width, one padding on each side)

[ire, 2017/10/17 15:03:35]

Done.

+  width: 3em;
   height: 100%;
   border-left: 2px solid $gray-medium;

[juliandoucette, 2017/10/13 13:39:57]

NIT: This looks like 1px in the mockups? (The same applies elsewhere)

[ire, 2017/10/17 15:03:35]

We changed it to 2px because you said it was too thin when we used it in the
footer. (since this extends the .custom-select

[juliandoucette, 2017/11/02 15:22:18]

suggest: 1px lighter gray throughout

-  background-image: url(/img/png/arrow-down-icon-secondary.png);

[juliandoucette, 2017/10/13 13:39:56]

NIT: Can we use SVG or 2x PNG and fallback to 1x png somehow?

[ire, 2017/10/17 15:03:35]

I know it's possible to set multiple background-image urls (e.g.
`background-image: url(one.png), url(two.png)`), but these will be overlaid on
top of each other. I'm not sure what other methods there are to doing this. Will
look it up

[juliandoucette, 2017/10/18 15:04:11]

https://css-tricks.com/svg-fallbacks/#article-header-id-4

[ire, 2017/10/20 13:40:48]

Neat! Done.

+  background-image: url(/img/png/arrow-icon-down-secondary.png);
+  background-image: linear-gradient(transparent, transparent), 
+                    url(/img/svg/arrow-icon-down-secondary.svg);
   background-repeat: no-repeat;
   background-position: center;
   background-size: 0.7em;
   content: "";
 }
 
 [dir="rtl"] .custom-select-dropdown .custom-select-selected:after
 {
   right: auto;
   left: 0;
   border-right: 2px solid $gray-medium;
   border-left: 0;
 }
 
 .custom-select-dropdown .custom-select-options
 {
   top: 100%;
   bottom: auto;
 }
-
-.custom-select-dropdown .custom-select-options li
-{
-  line-height: 40px;

[juliandoucette, 2017/10/13 13:39:56]

NIT: It's inconsistent to mix px and em here

[ire, 2017/10/17 15:03:35]

Done.

-}