Delta Between Two Patch Sets: includes/browser-select.tmpl
Issue 29559620:
Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Remove test class names from body
Created Oct. 23, 2017, 4:14 p.m.
Right Patch Set: Re-add browser-select include, add scripts block
Created Nov. 2, 2017, 2:29 p.m.
| Left: | ||
| Right: |
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with change/comment
|
« includes/adblockplus/remove-a-website-from-the-whitelist.md ('k')
|
pages/adblockplus/add-a-filter-list.md » ('j')
|
static/scss/components/_select.scss » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| LEFT | RIGHT |
|---|---|
| 1 <fieldset> | |
| 2 <label id="browser-select-label"> | |
| 3 {{ "Your Browser" | translate("browser-select-label", "Label") }}: | |
| 4 </label> | |
| 1 | 5 |
|
juliandoucette
2017/10/24 12:12:27
Suggest: <fieldset>?
ire
2017/10/27 10:22:56
Done.
| |
| 2 <label id="browser-select-label"> | 6 <div id="browser-select" class="custom-select custom-select-dropdown"> |
| 3 {{ "Your Browser" | translate("browser-select-label", "Label") }}: | 7 <button class="custom-select-selected" aria-expanded="false" aria-haspopup=" true"> |
| 4 </label> | 8 </button> |
| 5 | 9 <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby= "browser-select-label"> |
| 6 <div id="browser-select" class="custom-select custom-select-dropdown"> | 10 {% for browser in browsers %} |
| 7 <button class="custom-select-selected" aria-expanded="false" aria-haspopup="tr ue"> | 11 <li class="custom-select-option" role="menuitemradio" aria-checked="false" tabindex="0" data-value="{{ browser.id }}"> |
| 8 </button> | 12 <span class="has-pre-icon"> |
| 9 <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby="b rowser-select-label"> | 13 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}" ></span> |
| 10 {% for browser in browsers %} | 14 {{ browser.name | translate(browser.id + "-name") }} |
| 11 <li class="custom-select-option" role="menuitemradio" aria-checked="false" t abindex="0" data-value="{{ browser.id }}"> | 15 </span> |
| 12 <img src="/img/png/logo-abp.png" srcset="/img/svg/logo-abp.svg 2x"> | 16 </li> |
|
juliandoucette
2017/10/24 12:12:27
NIT: Missing alt text
ire
2017/10/27 10:22:56
Done.
| |
| 13 {{ browser.name | translate(browser.id + "-name") }} | 17 {% endfor %} |
| 14 </li> | 18 </ul> |
| 15 {% endfor %} | 19 </div> |
| 16 </ul> | 20 </fieldset> |
| 17 </div> | |
| 18 | 21 |
| 19 <script id="browser-select-autodetected" type="text/template">{{ "autodetected" | translate("browser-select-autodetected") }}</script> | 22 <script id="browser-select-autodetected" type="text/template">{{ "autodetected" | translate("browser-select-autodetected") }}</script> |
| LEFT | RIGHT |
« includes/adblockplus/remove-a-website-from-the-whitelist.md ('k')
|
pages/adblockplus/add-a-filter-list.md » ('j')
|
Toggle Intra-line Diffs ('i')
|
Expand Comments ('e')
|
Collapse Comments ('c')
|
Toggle Comments ('s')
