Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Delta Between Two Patch Sets: static/scss/components/_select.scss

Issue 29559620: Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Left Patch Set: Extend CustomSelect, address NITs Created Oct. 27, 2017, 10:22 a.m.
Right Patch Set: Re-add browser-select include, add scripts block Created Nov. 2, 2017, 2:29 p.m.
Left:
Right:
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
Left: Side by side diff | Download
Right: Side by side diff | Download
« no previous file with change/comment | « static/scss/components/_browser-select.scss ('k') | static/scss/main.scss » ('j') | no next file with change/comment »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
LEFTRIGHT
1 // This file is part of help.eyeo.com. 1 // This file is part of help.eyeo.com.
2 // Copyright (C) 2017 Eyeo GmbH 2 // Copyright (C) 2017 Eyeo GmbH
3 // 3 //
4 // help.eyeo.com is free software: you can redistribute it and/or modify 4 // help.eyeo.com is free software: you can redistribute it and/or modify
5 // it under the terms of the GNU General Public License as published by 5 // it under the terms of the GNU General Public License as published by
6 // the Free Software Foundation, either version 3 of the License, or 6 // the Free Software Foundation, either version 3 of the License, or
7 // (at your option) any later version. 7 // (at your option) any later version.
8 // 8 //
9 // help.eyeo.com is distributed in the hope that it will be useful, 9 // help.eyeo.com is distributed in the hope that it will be useful,
10 // but WITHOUT ANY WARRANTY; without even the implied warranty of 10 // but WITHOUT ANY WARRANTY; without even the implied warranty of
(...skipping 85 matching lines...) Expand 10 before | Expand all | Expand 10 after
96 { 96 {
97 content: none; 97 content: none;
98 } 98 }
99 99
100 a 100 a
101 { 101 {
102 color: inherit; 102 color: inherit;
103 } 103 }
104 } 104 }
105 105
106 .custom-select-option 106 .custom-select-option
juliandoucette 2017/11/02 15:22:19 suggest: change background-color on hove/active/fo
ire 2017/11/03 08:45:36 I'll probably handle this in the other issue handl
107 { 107 {
108 padding: 0.7em; 108 padding: 0.7em;
109 } 109 }
110 110
111 // Custom Dropdown (extends the custom select element) 111 // Custom Dropdown (extends the custom select element)
juliandoucette 2017/11/02 15:22:18 suggest: category comment (underline it)
ire 2017/11/03 08:45:36 Will change all comments in a separate issue
112 112
113 .custom-select-dropdown img
114 {
115 @extend .heading-icon;
116 }
117
118 .custom-select-dropdown .custom-select-selected, 113 .custom-select-dropdown .custom-select-selected,
119 .custom-select-dropdown .custom-select-options 114 .custom-select-dropdown .custom-select-options
120 { 115 {
121 width: 100%; 116 width: 100%;
122 } 117 }
123 118
124 .custom-select-dropdown .custom-select-selected 119 .custom-select-dropdown .custom-select-selected
125 { 120 {
126 position: relative; 121 position: relative;
127 height: 2.5em; 122 height: 2.5em;
(...skipping 10 matching lines...) Expand all
138 text-align: right; 133 text-align: right;
139 } 134 }
140 135
141 .custom-select-dropdown .custom-select-selected:after 136 .custom-select-dropdown .custom-select-selected:after
142 { 137 {
143 position: absolute; 138 position: absolute;
144 top: 0; 139 top: 0;
145 right: 0; 140 right: 0;
146 width: 3em; 141 width: 3em;
147 height: 100%; 142 height: 100%;
148 border-left: 2px solid $gray-medium; 143 border-left: 2px solid $gray-medium;
juliandoucette 2017/11/02 15:22:18 suggest: 1px lighter gray throughout
149 background-image: url(/img/png/arrow-icon-down-secondary.png); 144 background-image: url(/img/png/arrow-icon-down-secondary.png);
150 background-image: linear-gradient(transparent, transparent), 145 background-image: linear-gradient(transparent, transparent),
151 url(/img/svg/arrow-icon-down-secondary.svg); 146 url(/img/svg/arrow-icon-down-secondary.svg);
152 background-repeat: no-repeat; 147 background-repeat: no-repeat;
153 background-position: center; 148 background-position: center;
154 background-size: 0.7em; 149 background-size: 0.7em;
155 content: ""; 150 content: "";
156 } 151 }
157 152
158 [dir="rtl"] .custom-select-dropdown .custom-select-selected:after 153 [dir="rtl"] .custom-select-dropdown .custom-select-selected:after
159 { 154 {
160 right: auto; 155 right: auto;
161 left: 0; 156 left: 0;
162 border-right: 2px solid $gray-medium; 157 border-right: 2px solid $gray-medium;
163 border-left: 0; 158 border-left: 0;
164 } 159 }
165 160
166 .custom-select-dropdown .custom-select-options 161 .custom-select-dropdown .custom-select-options
167 { 162 {
168 top: 100%; 163 top: 100%;
169 bottom: auto; 164 bottom: auto;
170 } 165 }
LEFTRIGHT

Powered by Google App Engine
This is Rietveld