 Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com
    
  
    Issue 29559620:
  Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com  (Closed) 
  Base URL: https://hg.adblockplus.org/help.eyeo.com| Left: | ||
| Right: | 
| LEFT | RIGHT | 
|---|---|
| 1 {% extends "templates/minimal" %} | 1 {% extends "templates/minimal" %} | 
| 2 | 2 | 
| 3 {% set product = products[product_id] %} | 3 {% set product = products[product_id] %} | 
| 4 | 4 | 
| 5 {% block body %} | 5 {% block body %} | 
| 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> | 6 <nav aria-label="{{ "Breadcrumb" | translate("breadcrumb-label", "Label") }}" cl ass="breadcrumb"> | 
| 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> | 7 <ol class="container large-desktop-width clearfix" itemscope itemtype="http:// schema.org/BreadcrumbList"> | 
| 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 8 <li itemprop="itemListElement" itemscope itemtype="http://schema.org/ListIte m"> | 
| 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> | 9 <a class="has-pre-icon" itemscope itemtype="http://schema.org/Thing" itemp rop="item" href="{{ product.slug }}"> | 
| 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> | 10 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) }}">< /span> | 
| (...skipping 16 matching lines...) Expand all Loading... | |
| 27 <article class="article card {{ product_id }}-card section"> | 27 <article class="article card {{ product_id }}-card section"> | 
| 28 <header class="article-heading"> | 28 <header class="article-heading"> | 
| 29 <h1 class="has-pre-icon"> | 29 <h1 class="has-pre-icon"> | 
| 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> | 30 <span class="pre-icon" style="{{ get_inline_bg('logo-'+product_id) } }"></span> | 
| 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} | 31 {{ title | translate( get_page_name(page) + "-title", "Article title ") }} | 
| 32 </h1> | 32 </h1> | 
| 33 </header> | 33 </header> | 
| 34 | 34 | 
| 35 {% if hide_browser_selector is not defined %} | 35 {% if hide_browser_selector is not defined %} | 
| 36 <div class="article-browser-selector"> | 36 <div class="article-browser-selector"> | 
| 37 [Browser selector] | 37 <? include browser-select ?> | 
| 38 </div> | 38 </div> | 
| 39 {% endif %} | 39 {% endif %} | 
| 40 | 40 | 
| 41 <div class="article-body content"> | 41 <div class="article-body content"> | 
| 42 {{ body | safe }} | 42 {{ body | safe }} | 
| 43 </div> | 43 </div> | 
| 44 </article> | 44 </article> | 
| 45 </div> | 45 </div> | 
| 46 <aside class="section column one-third"> | 46 <aside class="section column one-third"> | 
| 47 <? include product-topics-accordion ?> | 47 <? include product-topics-accordion ?> | 
| 48 </aside> | 48 </aside> | 
| 49 </div> | 49 </div> | 
| 50 </main> | 50 </main> | 
| 51 | 51 | 
| 52 <script id="no-content-for-platform-message" type="text/template"> | 52 <script id="no-content-for-platform-message" type="text/template"> | 
| 53 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> | 53 <p>{{ "Unfortunately, there is no content specific for your current browser. P lease use the dropdown menu above to choose a different browser." | translate("n o-content-for-platform-message", "paragraph") }}</p> | 
| 54 </script> | 54 </script> | 
| 55 | |
| 56 <script src="/js/vendor/bowser.js"></script> | |
| 
juliandoucette
2017/11/02 13:10:56
suggest: We could add scripts like these to a scri
 
ire
2017/11/02 14:31:14
Good idea. Done.
I think it might also be a good
 | |
| 57 {% endblock %} | 55 {% endblock %} | 
| 58 | 56 | 
| 59 {% block footer %} | 57 {% block footer %} | 
| 60 <? include contact ?> | 58 <? include contact ?> | 
| 61 {% endblock %} | 59 {% endblock %} | 
| 60 | |
| 61 {% block scripts %} | |
| 62 <script src="/js/vendor/bowser.js"></script> | |
| 63 {% endblock %} | |
| LEFT | RIGHT |