Unified Diff: includes/browser-select.tmpl
Issue 29559620:
Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed)
Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Rebased
Created Oct. 11, 2017, 5:20 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« no previous file with comments
|
« globals/browsers.py ('k')
|
static/img/png/arrow-down-icon-secondary.png » ('j')
|
static/js/main.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: includes/browser-select.tmpl |
| =================================================================== |
| new file mode 100644 |
| --- /dev/null |
| +++ b/includes/browser-select.tmpl |
| @@ -0,0 +1,18 @@ |
| + |
|
juliandoucette
2017/10/13 13:39:55
NIT: Regarding the no-js state of this component:
ire
2017/10/17 15:03:33
I think I will hide it entirely. Because each sect
ire
2017/10/17 15:03:33
Done.
juliandoucette
2017/10/18 15:04:10
NIT: Adding an id (too) would make them deep linka
ire
2017/10/20 13:40:46
The issue with adding an id was because of section
|
| +<label id="browser-select-label"> |
| + {{ "Your Browser" | translate("browser-select-label", "Label") }}: |
| +</label> |
| + |
| +<div id="browser-select" class="custom-select custom-select-dropdown"> |
| + <button class="custom-select-selected" aria-expanded="false" aria-haspopup="true"> |
| + </button> |
| + <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby="browser-select-label"> |
| + {% for browser in browsers %} |
| + <li class="custom-select-option" role="button" tabindex="0" data-value="{{ browser.id }}"> |
|
juliandoucette
2017/10/13 13:39:55
NIT/Suggest: role="menuitemradio" aria-checked="fa
ire
2017/10/17 15:03:33
Done.
|
| + <img src="/img/png/logo-abp.png" srcset="/img/svg/logo-abp.svg 2x"> |
|
juliandoucette
2017/10/13 13:39:55
Note: Assuming you will replace these icons
ire
2017/10/17 15:03:33
Yes I mentioned that I am still waiting on the ico
juliandoucette
2017/10/18 15:04:10
Acknowledged.
|
| + {{ browser.name | translate(browser.id + "-name") }} |
|
juliandoucette
2017/10/13 13:39:55
Missing (autodetected) label?
(See comment js fil
ire
2017/10/17 15:03:33
Acknowledged.
|
| + </li> |
| + {% endfor %} |
| + </ul> |
| +</div> |
| + |
« no previous file with comments
|
« globals/browsers.py ('k')
|
static/img/png/arrow-down-icon-secondary.png » ('j')
|
static/js/main.js » ('J')
