Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code

Unified Diff: includes/browser-select.tmpl

Issue 29559620: Issue 5692 - Create Browser Selector with Browser Detection Component for help.eyeo.com (Closed) Base URL: https://hg.adblockplus.org/help.eyeo.com
Patch Set: Remove test class names from body Created Oct. 23, 2017, 4:14 p.m.
Use n/p to move between diff chunks; N/P to move between comments.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: includes/browser-select.tmpl
===================================================================
new file mode 100644
--- /dev/null
+++ b/includes/browser-select.tmpl
@@ -0,0 +1,19 @@
+
juliandoucette 2017/10/24 12:12:27 Suggest: <fieldset>?
ire 2017/10/27 10:22:56 Done.
+<label id="browser-select-label">
+ {{ "Your Browser" | translate("browser-select-label", "Label") }}:
+</label>
+
+<div id="browser-select" class="custom-select custom-select-dropdown">
+ <button class="custom-select-selected" aria-expanded="false" aria-haspopup="true">
+ </button>
+ <ul class="custom-select-options" role="menu" tabindex="-1" aria-labelledby="browser-select-label">
+ {% for browser in browsers %}
+ <li class="custom-select-option" role="menuitemradio" aria-checked="false" tabindex="0" data-value="{{ browser.id }}">
+ <img src="/img/png/logo-abp.png" srcset="/img/svg/logo-abp.svg 2x">
juliandoucette 2017/10/24 12:12:27 NIT: Missing alt text
ire 2017/10/27 10:22:56 Done.
+ {{ browser.name | translate(browser.id + "-name") }}
+ </li>
+ {% endfor %}
+ </ul>
+</div>
+
+<script id="browser-select-autodetected" type="text/template">{{ "autodetected" | translate("browser-select-autodetected") }}</script>

Powered by Google App Engine
This is Rietveld