Issue 5803 - rename new-options to options

In order to integrate new options page into the adblockpluschrome repository, first it will make sense to rename relevant files as a transition "from new to the current one".

[saroyanm, 2017-09-29 16:40:21]

Thomas can you please have a look

[Thomas Greiner, 2017-09-29 16:51:10]

https://codereview.adblockplus.org/29559679/diff/29559680/README.md
File README.md (right):

https://codereview.adblockplus.org/29559679/diff/29559680/README.md#newcode89
README.md:89: This is the implementation of the Adblock Plus options page which
will be
Detail: Since we're removing "new" from this sentence, we should also replace
"will be" with "is".

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js#n...
ext/background.js:83: if
(!/\/(?:mobile-options|options)\.html/.test(top.location.href))
Detail: The "options" part is duplicated so I'd suggest writing it as
`/\/(?:mobile-)?options\.html/` instead

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js#n...
ext/background.js:84: window.open("new-options.html", "_blank");
This string needs to be changed as well.

[saroyanm, 2017-09-29 17:09:33]

New patch uploaded

https://codereview.adblockplus.org/29559679/diff/29559680/README.md
File README.md (right):

https://codereview.adblockplus.org/29559679/diff/29559680/README.md#newcode89
README.md:89: This is the implementation of the Adblock Plus options page which
will be
On 2017/09/29 16:51:09, Thomas Greiner wrote:
> Detail: Since we're removing "new" from this sentence, we should also replace
> "will be" with "is".

Agree, Done.

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js
File ext/background.js (right):

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js#n...
ext/background.js:83: if
(!/\/(?:mobile-options|options)\.html/.test(top.location.href))
On 2017/09/29 16:51:09, Thomas Greiner wrote:
> Detail: The "options" part is duplicated so I'd suggest writing it as
> `/\/(?:mobile-)?options\.html/` instead

Good one, done.

https://codereview.adblockplus.org/29559679/diff/29559680/ext/background.js#n...
ext/background.js:84: window.open("new-options.html", "_blank");
On 2017/09/29 16:51:09, Thomas Greiner wrote:
> This string needs to be changed as well.

Right! Well spotted. Done.

[Thomas Greiner, 2017-09-29 17:34:08]

LGTM