README.md - Issue 29559679: Issue 5803 - rename new-options to options

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Delta Between Two Patch Sets: README.md

Issue 29559679: Issue 5803 - rename new-options to options (Closed)

Left Patch Set: Created Sept. 29, 2017, 4:34 p.m.

Right Patch Set: Created Sept. 29, 2017, 5:08 p.m.

Left:
Right:

Use n/p to move between diff chunks; N/P to move between comments.

Jump to:

Left: Side by side diff | Download
Right: Side by side diff | Download

LEFT	RIGHT
1 Shared Adblock Plus UI code	1 Shared Adblock Plus UI code

2 ===========================	2 ===========================

3	3

4 The user interface elements defined in this repository will be used by various	4 The user interface elements defined in this repository will be used by various

5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be	5 Adblock Plus products like Adblock Plus for Firefox. Their functionality can be

6 tested within this repository, even though they might not work exactly the same	6 tested within this repository, even though they might not work exactly the same

7 as they will do in the final product.	7 as they will do in the final product.

8	8

9 Directory structure	9 Directory structure

10 -------------------	10 -------------------

(...skipping 68 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
79 To aid testing, the behavior of this page is affected by a number of URL	79 To aid testing, the behavior of this page is affected by a number of URL

80 parameters:	80 parameters:

81	81

82 * `addSubscription=true`: this parameter should trigger a dialog for adding	82 * `addSubscription=true`: this parameter should trigger a dialog for adding

83 subscriptions as initiated by clicking on an "abp:subscribe" link	83 subscriptions as initiated by clicking on an "abp:subscribe" link

84 * `showPageOptions=true`: shows page-specific options	84 * `showPageOptions=true`: shows page-specific options

85	85

86 options.html	86 options.html

87 ------------	87 ------------

88	88

89 This is the implementation of the Adblock Plus options page which will be	89 This is the implementation of the Adblock Plus options page which is
Thomas Greiner 2017/09/29 16:51:09 Detail: Since we're removing "new" from this sente Detail: Since we're removing "new" from this sentence, we should also replace "will be" with "is". saroyanm 2017/09/29 17:09:32 Agree, Done. Show quoted text On 2017/09/29 16:51:09, Thomas Greiner wrote: > Detail: Since we're removing "new" from this sentence, we should also replace > "will be" with "is". Agree, Done.
90 the primary UI for changing settings and for managing filter lists.	90 the primary UI for changing settings and for managing filter lists.

91	91

92 To aid testing, the behavior of this page is affected by a number of URL	92 To aid testing, the behavior of this page is affected by a number of URL

93 parameters:	93 parameters:

94	94

95 * `addonVersion`: sets addon version application parameter that is used for	95 * `addonVersion`: sets addon version application parameter that is used for

96 creating the link to the version-specific release notes	96 creating the link to the version-specific release notes

97 * `addSubscription=true`: this parameter should trigger a dialog for adding	97 * `addSubscription=true`: this parameter should trigger a dialog for adding

98 subscriptions as initiated by clicking on an "abp:subscribe" link	98 subscriptions as initiated by clicking on an "abp:subscribe" link

99 * `filterError=true`: causes filter validation to fail, showing validation	99 * `filterError=true`: causes filter validation to fail, showing validation

(...skipping 11 matching lines...) Expand all Loading...
111 Linting	111 Linting

112 -------	112 -------

113	113

114 You can lint the code using [ESLint](http://eslint.org).	114 You can lint the code using [ESLint](http://eslint.org).

115	115

116 eslint *.js lib ext	116 eslint *.js lib ext

117	117

118 You will need to set up ESLint and our configuration first, see	118 You will need to set up ESLint and our configuration first, see

119 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)	119 [eslint-config-eyeo](https://hg.adblockplus.org/codingtools/file/tip/eslint-conf ig-eyeo)

120 for more information.	120 for more information.

LEFT	RIGHT