Unified Diff: ext/background.js
Issue 29559679:
Issue 5803 - rename new-options to options (Closed)
Patch Set:
Created Sept. 29, 2017, 4:34 p.m.
Use n/p to move between diff chunks;
N/P to move between comments.
« README.md ('K')
|
« README.md ('k')
|
locale/en-US/options.json » ('j')
|
no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')
| Index: ext/background.js |
| =================================================================== |
| --- a/ext/background.js |
| +++ b/ext/background.js |
| @@ -80,7 +80,7 @@ |
| window.ext.showOptions = function(callback) |
| { |
| - if (!/\/(?:mobile|new)-options\.html/.test(top.location.href)) |
| + if (!/\/(?:mobile-options|options)\.html/.test(top.location.href)) |
|
Thomas Greiner
2017/09/29 16:51:09
Detail: The "options" part is duplicated so I'd su
saroyanm
2017/09/29 17:09:32
Good one, done.
|
| window.open("new-options.html", "_blank"); |
|
Thomas Greiner
2017/09/29 16:51:09
This string needs to be changed as well.
saroyanm
2017/09/29 17:09:32
Right! Well spotted. Done.
|
| if (callback) |
« README.md ('K')
|
« README.md ('k')
|
locale/en-US/options.json » ('j')
|
no next file with comments »
