Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(16)

Issue 29560569: Issue 5815 - Fixed Crowdin upload with non-ASCII characters (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by Sebastian Noack
Modified:
2 years, 1 month ago
Visibility:
Public.

Description

Issue 5815 - Fixed Crowdin upload with non-ASCII characters

Patch Set 1 #

Total comments: 4

Patch Set 2 : Put each argument on seperate line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -3 lines) Patch
M localeTools.py View 1 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 5
Sebastian Noack
https://codereview.adblockplus.org/29560569/diff/29560570/localeTools.py File localeTools.py (right): https://codereview.adblockplus.org/29560569/diff/29560570/localeTools.py#newcode356 localeTools.py:356: data=data.encode('utf-8'), data is a unicode object. When passing any ...
2 years, 1 month ago (2017-10-01 02:42:07 UTC) #1
Vasily Kuznetsov
Hi Sebastian, One little suggestion below but I don't feel strongly about it, so LGTM ...
2 years, 1 month ago (2017-10-01 09:54:28 UTC) #2
tlucas
Hey guys, LGTM
2 years, 1 month ago (2017-10-01 10:41:25 UTC) #3
Sebastian Noack
https://codereview.adblockplus.org/29560569/diff/29560570/localeTools.py File localeTools.py (right): https://codereview.adblockplus.org/29560569/diff/29560570/localeTools.py#newcode355 localeTools.py:355: ).format(boundary=boundary, name=name, On 2017/10/01 09:54:28, Vasily Kuznetsov wrote: > ...
2 years, 1 month ago (2017-10-01 14:20:54 UTC) #4
Vasily Kuznetsov
2 years, 1 month ago (2017-10-01 14:28:11 UTC) #5
even more LGTM ;)
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 87257f5